ui: fix filtering for flame chart visualization#6228
Merged
manojVivek merged 6 commits intomainfrom Mar 17, 2026
Merged
Conversation
|
✅ Meticulous spotted 0 visual differences across 315 screens tested: view results. Meticulous evaluated ~4 hours of user flows against your PR. Expected differences? Click here. Last updated for commit 1d46c7c. This comment will update as new commits are pushed. |
manojVivek
reviewed
Mar 11, 2026
| const isGraphViz = dashboardItems?.includes('flamegraph'); | ||
| const isGraphVizOnly = dashboardItems?.length === 1 && isGraphViz; | ||
| const isFlamechartViz = dashboardItems?.includes('flamechart'); | ||
| const isFlamechartVizOnly = dashboardItems?.length === 1 && isFlamechartViz; |
manojVivek
approved these changes
Mar 11, 2026
Contributor
manojVivek
left a comment
manojVivek
left a comment
There was a problem hiding this comment.
Looking great!
Had it disabled as I was not sure if the backend was handling it well.
manojVivek
reviewed
Mar 11, 2026
Contributor
manojVivek
left a comment
manojVivek
left a comment
There was a problem hiding this comment.
From the screenshot, it looks like the data in the samples strips is not filtered for the query. Is that fine?
Member
Author
Good catch! We should do that too! I just didn't realize it was happening. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This is temporarily disabled for Parca as the samples strips data filtering is not feasible with the backend right now.
Problem
Two related issues prevented filtering from working in the flame chart view:
Filter UI was hidden —
ProfileFilterswas wrapped in!isFlamechartVizOnlyinToolbars/index.tsx, so the filter button never appeared when flame chart was the sole visualization.Filters weren't sent in the query —
ProfileFlameChartcalleduseQuery()without passingprotoFilters, so even if the UI had been visible, any applied filters would have been silently ignored.Screenshots
Before without filterting
After with filterting (for malloc)
Notes
cc @manojVivek — removing the guard you added in #6192, now that the filters are actually wired up to the query.