Skip to content

[docs-only] Update check-env-var-annotoation.sh script#12176

Merged
mmattel merged 1 commit intomasterfrom
update_check_envvar_version_annotion
Apr 7, 2026
Merged

[docs-only] Update check-env-var-annotoation.sh script#12176
mmattel merged 1 commit intomasterfrom
update_check_envvar_version_annotion

Conversation

@mmattel
Copy link
Copy Markdown
Contributor

@mmattel mmattel commented Apr 1, 2026

This PR updates the check-envvar-version-annotion.sh script:

  • Remove complexity in regex
  • Add more valid/invalid examples
    Note that allowing major.minor without a patch version is historically driven and cant be removed easily.
    The dev docs tell to use m.m.p for a final semver.
  • Reduce grep steps and complexity
  • Update dev docs
  • The referenced helper script used to identify placeholder introductionVersions is created in another PR.
  • Color any found issue in the output
    Formerly there was only the whole string that contained the problem, see the image for an example how it looks now. Note that the image is based on a locally created artificial issue that is not present in ocis...
image

@mmattel mmattel enabled auto-merge (rebase) April 1, 2026 17:48
@mmattel mmattel force-pushed the update_check_envvar_version_annotion branch 6 times, most recently from 5100d3a to 25e43a5 Compare April 7, 2026 09:46
auto-merge was automatically disabled April 7, 2026 12:19

Rebase merges are not allowed on this repository

Signed-off-by: Martin Mattel <github@diemattels.at>
@mmattel mmattel force-pushed the update_check_envvar_version_annotion branch from 25e43a5 to 42a7c5f Compare April 7, 2026 12:46
@mmattel mmattel enabled auto-merge April 7, 2026 13:10
@mmattel mmattel merged commit 5ea1da9 into master Apr 7, 2026
55 checks passed
@mmattel mmattel deleted the update_check_envvar_version_annotion branch April 7, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants