zfs receive: add test to reproduce issue #18344#18355
Open
GarthSnyder wants to merge 1 commit intoopenzfs:masterfrom
Open
zfs receive: add test to reproduce issue #18344#18355GarthSnyder wants to merge 1 commit intoopenzfs:masterfrom
GarthSnyder wants to merge 1 commit intoopenzfs:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a ZFS Test Suite case intended to reproduce OpenZFS issue #18344 (failure to zfs receive a redacted send stream produced on the opposite endianness), by shipping pre-recorded redacted send streams for both byte orders and a harness that selects the opposite-endian stream at runtime.
Changes:
- Add
redacted_opposite_endianfunctional test that attempts to receive a prebuilt opposite-endian redacted stream intoPOOL2. - Add big-endian and little-endian redacted send streams (
.zsend.bz2) to the test data distribution. - Register the new test in the runfile and mark it as a known failure linked to issue #18344 in
zts-report.py.in.
Reviewed changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/zfs-tests/tests/Makefile.am | Distributes the new opposite-endian stream artifacts and installs the new test script. |
| tests/zfs-tests/tests/functional/redacted_send/redacted_opposite_endian.ksh | New test selecting an opposite-endian stream and running `bzcat |
| tests/zfs-tests/tests/functional/redacted_send/little-endian-redacted.zsend.bz2 | Adds a prebuilt little-endian redacted send stream fixture. |
| tests/zfs-tests/tests/functional/redacted_send/big-endian-redacted.zsend.bz2 | Adds a prebuilt big-endian redacted send stream fixture. |
| tests/test-runner/bin/zts-report.py.in | Marks the new test as a known failure tied to GitHub issue 18344. |
| tests/runfiles/common.run | Includes redacted_opposite_endian in the redacted_send functional test group. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tests/zfs-tests/tests/functional/redacted_send/redacted_opposite_endian.ksh
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tests/zfs-tests/tests/functional/redacted_send/redacted_opposite_endian.ksh
Outdated
Show resolved
Hide resolved
This is a test that demonstrates issue openzfs#18344. I've added redacted streams of both endiannesses and a harness that attempts to zfs recv the opposite-endian version. This should be marked as a known issue if I've set it up correctly. Signed-off-by: Garth Snyder <garth@garthsnyder.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a test that demonstrates issue #18344. I've added redacted streams of both endiannesses and a harness that attempts to zfs recv the opposite-endian version. This should be marked as a known issue if I've set it up correctly.
Types of changes
Checklist:
Signed-off-by.