Skip to content

Add multiplyDivide function to fixed-point types #4478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
turbolent wants to merge 9 commits into
base: bastian/fixed-point-rounding
Choose a base branch
from
Open

Add multiplyDivide function to fixed-point types #4478

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cade23a
add pow function to UFix64 and UFix128
turbolent Apr 18, 2026
82ed5b0
test type-checking of fixed-point pow function
turbolent Apr 20, 2026
5883942
Merge branch 'bastian/fixed-point-rounding' into bastian/fixed-point-fmd
turbolent Apr 20, 2026
debc2be
add multiplyDivide function to fixed-point types
turbolent Apr 20, 2026
344a5af
fix registration of fixed-point types with pow function
turbolent Apr 22, 2026
5a3025e
Merge branch 'bastian/fixed-point-pow' into bastian/fixed-point-fmd
turbolent Apr 22, 2026
fab5f47
fix registration of multiplyDivide function types
turbolent Apr 22, 2026
a8ecde8
make rounding parameter of multiplyDivide optional
turbolent Apr 23, 2026
006b1fb
refactor how expected value is created in existing tests
turbolent Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions bbq/vm/builtin_globals.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,10 @@ func init() {
registerBuiltinCommonTypeBoundFunctions()

registerBuiltinSaturatingArithmeticFunctions()

registerBuiltinFixedPointPowFunctions()

registerBuiltinFixedPointMultiplyDivideFunctions()
}

func registerBuiltinCommonTypeBoundFunctions() {
Expand Down Expand Up @@ -429,6 +433,32 @@ func registerBuiltinTypeSaturatingArithmeticFunctions(t sema.SaturatingArithmeti
}
}

func registerBuiltinFixedPointPowFunctions() {
for baseType, funcType := range sema.FixedPointPowFunctionTypes { //nolint:maprange
registerBuiltinTypeBoundFunction(
commons.TypeQualifier(baseType),
NewNativeFunctionValue(
sema.FixedPointNumericTypePowFunctionName,
funcType,
interpreter.NativeFixedPointPowFunction,
),
)
}
}

func registerBuiltinFixedPointMultiplyDivideFunctions() {
for baseType, funcType := range sema.FixedPointMultiplyDivideFunctionTypes {
registerBuiltinTypeBoundFunction(
commons.TypeQualifier(baseType),
NewNativeFunctionValue(
sema.FixedPointNumericTypeMultiplyDivideFunctionName,
funcType,
interpreter.NativeFixedPointMultiplyDivideFunction,
),
)
}
}

func newFromStringFunction(typedParser interpreter.TypedStringValueParser) *NativeFunctionValue {
functionType := sema.FromStringFunctionType(typedParser.ReceiverType)
parser := typedParser.Parser
Expand Down
Loading