Add multiplyDivide function to fixed-point types#4478
Open
turbolent wants to merge 9 commits intobastian/fixed-point-roundingfrom
Open
Add multiplyDivide function to fixed-point types#4478turbolent wants to merge 9 commits intobastian/fixed-point-roundingfrom
turbolent wants to merge 9 commits intobastian/fixed-point-roundingfrom
Conversation
turbolent
changed the title
follow existing pattern already used by saturating arithmetic functions
turbolent
force-pushed
the
bastian/fixed-point-fmd
branch
from
522a819 to
fab5f47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #4474
Depends on #4473
Description
Add a
multiplyDividefunction to all fixed-point types, backed byFMDmethods in https://github.com/onflow/fixed-point:Fix64.multiplyDivide(_ factor: Fix64, _ divisor: Fix64, rounding: RoundingRule): Fix64UFix64.multiplyDivide(_ factor: UFix64, _ divisor: UFix64, rounding: RoundingRule): UFix64Fix128.multiplyDivide(_ factor: Fix128, _ divisor: Fix128, rounding: RoundingRule): Fix128UFix128.multiplyDivide(_ factor: UFix128, _ divisor: UFix128, rounding: RoundingRule): UFix128masterbranchFiles changedin the Github PR explorer