Add pow function to UFix64 and UFix128 by turbolent · Pull Request #4473 · onflow/cadence

turbolent · 2026-04-18T00:01:51Z

Work towards #1151

Description

Add pow function to UFix64 and UFix128 fixed-point types, backed by Pow methods in https://github.com/onflow/fixed-point:

UFix64.pow(_ exponent: Fix64): UFix64
UFix128.pow(_ exponent: Fix128): UFix128

Targeted PR against master branch
Linked to Github issue with discussion and accepted design OR link to spec that describes this work
Code follows the standards mentioned here
Updated relevant documentation
Re-reviewed Files changed in the Github PR explorer
Added appropriate labels

github-actions · 2026-04-18T00:02:04Z

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

github-actions · 2026-04-18T00:09:49Z

Benchstat comparison

Base branch: onflow:master
Base commit: e8fe69b

Results

	old.txt	new.txt
	time/op		delta
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ByteArrayTransfer-4	1.22µs ± 0%	1.24µs ± 0%	~	(p=1.000 n=1+1)
ByteArrayValueToByteSlice-4	74.4ns ± 0%	77.2ns ± 0%	~	(p=1.000 n=1+1)
ByteSliceToByteArrayValue-4	879ns ± 0%	979ns ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/compiler goos:linux goarch:amd64
CompileFungibleTokenTransferTransaction-4	123µs ± 0%	126µs ± 0%	~	(p=1.000 n=1+1)
CompileTime-4	36.8µs ± 0%	36.4µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ContractFunctionInvocation-4	374µs ± 0%	372µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
ContractImport-4	209µs ± 0%	223µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
EMVAddressTransfer-4	3.10µs ± 0%	3.34µs ± 0%	~	(p=1.000 n=1+1)
Emit-4	4.29ms ± 0%	4.43ms ± 0%	~	(p=1.000 n=1+1)
EnumTransfer-4	1.23µs ± 0%	1.35µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ExportType/composite_type-4	246ns ± 0%	283ns ± 0%	~	(p=1.000 n=1+1)
ExportType/simple_type-4	73.6ns ± 0%	74.9ns ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
FTTransfer-4	147µs ± 0%	149µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/sema goos:linux goarch:amd64
FlowTokenContract-4	585µs ± 0%	604µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ImperativeFib-4	22.1µs ± 0%	21.9µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
ImperativeFib-4	24.2µs ± 0%	23.6µs ± 0%	~	(p=1.000 n=1+1)
ImperativeFibNewCompilerNewVM-4	49.6µs ± 0%	47.7µs ± 0%	~	(p=1.000 n=1+1)
ImperativeFibNewVM-4	27.2µs ± 0%	28.1µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
InterpretRecursionFib-4	2.24ms ± 0%	2.28ms ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
InterpreterFTTransfer-4	121µs ± 0%	125µs ± 0%	~	(p=1.000 n=1+1)
InterpreterImperativeFib-4	23.4µs ± 0%	21.8µs ± 0%	~	(p=1.000 n=1+1)
InterpreterNewStruct-4	63.1µs ± 0%	63.7µs ± 0%	~	(p=1.000 n=1+1)
MethodCall/concrete_type_method_call-4	42.2µs ± 0%	43.6µs ± 0%	~	(p=1.000 n=1+1)
MethodCall/interface_method_call-4	59.3µs ± 0%	59.3µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
NewInterpreter/new_interpreter-4	871ns ± 0%	822ns ± 0%	~	(p=1.000 n=1+1)
NewInterpreter/new_sub-interpreter-4	314ns ± 0%	337ns ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
NewResource-4	100µs ± 0%	100µs ± 0%	~	(p=1.000 n=1+1)
NewStruct-4	43.9µs ± 0%	44.1µs ± 0%	~	(p=1.000 n=1+1)
NewStructRaw-4	3.01µs ± 0%	2.89µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/sema goos:linux goarch:amd64
QualifiedIdentifierCreation/One_level-4	2.04ns ± 0%	2.05ns ± 0%	~	(p=1.000 n=1+1)
QualifiedIdentifierCreation/Three_levels-4	77.4ns ± 0%	78.0ns ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
RecursionFib-4	1.56ms ± 0%	1.51ms ± 0%	~	(p=1.000 n=1+1)
RuntimeFungibleTokenTransfer-4	731µs ± 0%	706µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
RuntimeFungibleTokenTransferInterpreter-4	596µs ± 0%	609µs ± 0%	~	(p=1.000 n=1+1)
RuntimeFungibleTokenTransferVM-4	664µs ± 0%	679µs ± 0%	~	(p=1.000 n=1+1)
RuntimeResourceDictionaryValues-4	2.58ms ± 0%	2.72ms ± 0%	~	(p=1.000 n=1+1)
RuntimeResourceTracking-4	9.34ms ± 0%	9.26ms ± 0%	~	(p=1.000 n=1+1)
RuntimeScriptNoop-4	13.9µs ± 0%	14.0µs ± 0%	~	(p=1.000 n=1+1)
RuntimeVMInvokeContractImperativeFib-4	39.7µs ± 0%	41.4µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/sema goos:linux goarch:amd64
SuperTypeInference/arrays-4	223ns ± 0%	214ns ± 0%	~	(p=1.000 n=1+1)
SuperTypeInference/composites-4	83.7ns ± 0%	88.1ns ± 0%	~	(p=1.000 n=1+1)
SuperTypeInference/integers-4	295ns ± 0%	301ns ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ValueIsSubtypeOfSemaType-4	57.6ns ± 0%	57.2ns ± 0%	~	(p=1.000 n=1+1)

	alloc/op		delta
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ByteArrayTransfer-4	1.06kB ± 0%	1.06kB ± 0%	~	(p=1.000 n=1+1)
ByteArrayValueToByteSlice-4	32.0B ± 0%	32.0B ± 0%	~	(all equal)
ByteSliceToByteArrayValue-4	850B ± 0%	859B ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/compiler goos:linux goarch:amd64
CompileFungibleTokenTransferTransaction-4	82.9kB ± 0%	82.9kB ± 0%	~	(p=1.000 n=1+1)
CompileTime-4	16.9kB ± 0%	16.9kB ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ContractFunctionInvocation-4	144kB ± 0%	144kB ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
ContractImport-4	75.4kB ± 0%	75.4kB ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
EMVAddressTransfer-4	2.45kB ± 0%	2.45kB ± 0%	~	(p=1.000 n=1+1)
Emit-4	1.49MB ± 0%	1.49MB ± 0%	~	(p=1.000 n=1+1)
EnumTransfer-4	890B ± 0%	893B ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ExportType/composite_type-4	120B ± 0%	120B ± 0%	~	(all equal)
ExportType/simple_type-4	0.00B	0.00B	~	(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
FTTransfer-4	43.7kB ± 0%	43.7kB ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/sema goos:linux goarch:amd64
FlowTokenContract-4	226kB ± 0%	226kB ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ImperativeFib-4	8.30kB ± 0%	8.30kB ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
ImperativeFib-4	5.41kB ± 0%	5.41kB ± 0%	~	(all equal)
ImperativeFibNewCompilerNewVM-4	25.8kB ± 0%	25.8kB ± 0%	~	(all equal)
ImperativeFibNewVM-4	8.10kB ± 0%	8.10kB ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
InterpretRecursionFib-4	1.19MB ± 0%	1.19MB ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
InterpreterFTTransfer-4	42.0kB ± 0%	42.0kB ± 0%	~	(p=1.000 n=1+1)
InterpreterImperativeFib-4	8.29kB ± 0%	8.29kB ± 0%	~	(all equal)
InterpreterNewStruct-4	24.9kB ± 0%	24.8kB ± 0%	~	(p=1.000 n=1+1)
MethodCall/concrete_type_method_call-4	10.2kB ± 0%	10.2kB ± 0%	~	(p=1.000 n=1+1)
MethodCall/interface_method_call-4	17.1kB ± 0%	17.1kB ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
NewInterpreter/new_interpreter-4	976B ± 0%	976B ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-4	232B ± 0%	232B ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
NewResource-4	44.0kB ± 0%	44.0kB ± 0%	~	(p=1.000 n=1+1)
NewStruct-4	13.4kB ± 0%	13.4kB ± 0%	~	(p=1.000 n=1+1)
NewStructRaw-4	1.75kB ± 0%	1.71kB ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/sema goos:linux goarch:amd64
QualifiedIdentifierCreation/One_level-4	0.00B	0.00B	~	(all equal)
QualifiedIdentifierCreation/Three_levels-4	64.0B ± 0%	64.0B ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
RecursionFib-4	283kB ± 0%	283kB ± 0%	~	(all equal)
RuntimeFungibleTokenTransfer-4	241kB ± 0%	242kB ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
RuntimeFungibleTokenTransferInterpreter-4	165kB ± 0%	165kB ± 0%	~	(p=1.000 n=1+1)
RuntimeFungibleTokenTransferVM-4	188kB ± 0%	188kB ± 0%	~	(p=1.000 n=1+1)
RuntimeResourceDictionaryValues-4	1.76MB ± 0%	1.76MB ± 0%	~	(p=1.000 n=1+1)
RuntimeResourceTracking-4	6.96MB ± 0%	6.96MB ± 0%	~	(p=1.000 n=1+1)
RuntimeScriptNoop-4	8.08kB ± 0%	8.07kB ± 0%	~	(p=1.000 n=1+1)
RuntimeVMInvokeContractImperativeFib-4	13.4kB ± 0%	13.4kB ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/sema goos:linux goarch:amd64
SuperTypeInference/arrays-4	72.0B ± 0%	72.0B ± 0%	~	(all equal)
SuperTypeInference/composites-4	0.00B	0.00B	~	(all equal)
SuperTypeInference/integers-4	0.00B	0.00B	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ValueIsSubtypeOfSemaType-4	32.0B ± 0%	32.0B ± 0%	~	(all equal)

	allocs/op		delta
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ByteArrayTransfer-4	7.00 ± 0%	7.00 ± 0%	~	(all equal)
ByteArrayValueToByteSlice-4	1.00 ± 0%	1.00 ± 0%	~	(all equal)
ByteSliceToByteArrayValue-4	5.00 ± 0%	5.00 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/bbq/compiler goos:linux goarch:amd64
CompileFungibleTokenTransferTransaction-4	576 ± 0%	576 ± 0%	~	(all equal)
CompileTime-4	209 ± 0%	209 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ContractFunctionInvocation-4	2.25k ± 0%	2.25k ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
ContractImport-4	1.29k ± 0%	1.29k ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
EMVAddressTransfer-4	29.0 ± 0%	29.0 ± 0%	~	(all equal)
Emit-4	40.0k ± 0%	40.0k ± 0%	~	(all equal)
EnumTransfer-4	13.0 ± 0%	13.0 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ExportType/composite_type-4	3.00 ± 0%	3.00 ± 0%	~	(all equal)
ExportType/simple_type-4	0.00	0.00	~	(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
FTTransfer-4	1.40k ± 0%	1.40k ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/sema goos:linux goarch:amd64
FlowTokenContract-4	3.58k ± 0%	3.58k ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ImperativeFib-4	176 ± 0%	176 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
ImperativeFib-4	266 ± 0%	266 ± 0%	~	(all equal)
ImperativeFibNewCompilerNewVM-4	473 ± 0%	473 ± 0%	~	(all equal)
ImperativeFibNewVM-4	308 ± 0%	308 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
InterpretRecursionFib-4	17.7k ± 0%	17.7k ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
InterpreterFTTransfer-4	916 ± 0%	916 ± 0%	~	(all equal)
InterpreterImperativeFib-4	175 ± 0%	175 ± 0%	~	(all equal)
InterpreterNewStruct-4	418 ± 0%	418 ± 0%	~	(all equal)
MethodCall/concrete_type_method_call-4	354 ± 0%	354 ± 0%	~	(all equal)
MethodCall/interface_method_call-4	464 ± 0%	464 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
NewInterpreter/new_interpreter-4	15.0 ± 0%	15.0 ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-4	4.00 ± 0%	4.00 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
NewResource-4	951 ± 0%	951 ± 0%	~	(all equal)
NewStruct-4	388 ± 0%	388 ± 0%	~	(all equal)
NewStructRaw-4	30.0 ± 0%	30.0 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/sema goos:linux goarch:amd64
QualifiedIdentifierCreation/One_level-4	0.00	0.00	~	(all equal)
QualifiedIdentifierCreation/Three_levels-4	2.00 ± 0%	2.00 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
RecursionFib-4	15.8k ± 0%	15.8k ± 0%	~	(all equal)
RuntimeFungibleTokenTransfer-4	4.09k ± 0%	4.09k ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
RuntimeFungibleTokenTransferInterpreter-4	3.08k ± 0%	3.08k ± 0%	~	(all equal)
RuntimeFungibleTokenTransferVM-4	3.61k ± 0%	3.61k ± 0%	~	(all equal)
RuntimeResourceDictionaryValues-4	36.7k ± 0%	36.7k ± 0%	~	(all equal)
RuntimeResourceTracking-4	129k ± 0%	129k ± 0%	~	(p=1.000 n=1+1)
RuntimeScriptNoop-4	114 ± 0%	114 ± 0%	~	(all equal)
RuntimeVMInvokeContractImperativeFib-4	426 ± 0%	426 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/sema goos:linux goarch:amd64
SuperTypeInference/arrays-4	3.00 ± 0%	3.00 ± 0%	~	(all equal)
SuperTypeInference/composites-4	0.00	0.00	~	(all equal)
SuperTypeInference/integers-4	0.00	0.00	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ValueIsSubtypeOfSemaType-4	1.00 ± 0%	1.00 ± 0%	~	(all equal)

codecov · 2026-04-18T00:27:22Z

Codecov Report

❌ Patch coverage is 94.31818% with 5 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
interpreter/value_number.go	76.19%	4 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

follow existing pattern already used by saturating arithmetic functions

turbolent self-assigned this Apr 18, 2026

turbolent added the Feature label Apr 18, 2026

turbolent requested a review from SupunS as a code owner April 18, 2026 00:01

add pow function to UFix64 and UFix128

cade23a

turbolent force-pushed the bastian/fixed-point-pow branch from 79cf240 to cade23a Compare April 18, 2026 00:17

test type-checking of fixed-point pow function

82ed5b0

turbolent mentioned this pull request Apr 20, 2026

Add multiplyDivide function to fixed-point types #4478

Open

6 tasks

SupunS reviewed Apr 22, 2026

View reviewed changes

Comment thread bbq/vm/builtin_globals.go

fix registration of fixed-point types with pow function

344a5af

follow existing pattern already used by saturating arithmetic functions

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add pow function to UFix64 and UFix128#4473

Add pow function to UFix64 and UFix128#4473
turbolent wants to merge 3 commits intomasterfrom
bastian/fixed-point-pow

turbolent commented Apr 18, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 18, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 18, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Apr 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

turbolent commented Apr 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

github-actions Bot commented Apr 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Dependency Review

Scanned Files

Uh oh!

github-actions Bot commented Apr 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchstat comparison

Uh oh!

codecov Bot commented Apr 18, 2026

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

turbolent commented Apr 18, 2026 •

edited

Loading

github-actions Bot commented Apr 18, 2026 •

edited

Loading

github-actions Bot commented Apr 18, 2026 •

edited

Loading