Skip to content

Address code review

b0208b3
Select commit
Loading
Failed to load commit list.
Open

Add Assert.Scope() for soft assertions #7355

Address code review
b0208b3
Select commit
Loading
Failed to load commit list.
Azure Pipelines / microsoft.testfx (Build Windows Release) failed Feb 9, 2026 in 8m 7s

Build Windows Release failed

Annotations

Check failure on line 40 in src\TestFramework\TestFramework\Assertions\AssertScope.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / microsoft.testfx (Build Windows Release)

src\TestFramework\TestFramework\Assertions\AssertScope.cs#L40

src\TestFramework\TestFramework\Assertions\AssertScope.cs(40,33): error CS0117: (NETCORE_ENGINEERING_TELEMETRY=Build) 'ObjectDisposedException' does not contain a definition for 'ThrowIf'

Check failure on line 60 in src\TestFramework\TestFramework\Assertions\AssertScope.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / microsoft.testfx (Build Windows Release)

src\TestFramework\TestFramework\Assertions\AssertScope.cs#L60

src\TestFramework\TestFramework\Assertions\AssertScope.cs(60,13): error CA1836: (NETCORE_ENGINEERING_TELEMETRY=Build) Prefer 'IsEmpty' over 'Count' to determine whether the object is empty (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1836)

Check failure on line 4 in src\TestFramework\TestFramework\Assertions\AssertScope.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / microsoft.testfx (Build Windows Release)

src\TestFramework\TestFramework\Assertions\AssertScope.cs#L4

src\TestFramework\TestFramework\Assertions\AssertScope.cs(4,1): error IDE0005: (NETCORE_ENGINEERING_TELEMETRY=Build) Using directive is unnecessary. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0005)

Check failure on line 4 in src\TestFramework\TestFramework\Assertions\Assert.Scope.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / microsoft.testfx (Build Windows Release)

src\TestFramework\TestFramework\Assertions\Assert.Scope.cs#L4

src\TestFramework\TestFramework\Assertions\Assert.Scope.cs(4,1): error IDE0005: (NETCORE_ENGINEERING_TELEMETRY=Build) Using directive is unnecessary. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0005)

Check failure on line 60 in src\TestFramework\TestFramework\Assertions\AssertScope.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / microsoft.testfx (Build Windows Release)

src\TestFramework\TestFramework\Assertions\AssertScope.cs#L60

src\TestFramework\TestFramework\Assertions\AssertScope.cs(60,13): error CA1836: (NETCORE_ENGINEERING_TELEMETRY=Build) Prefer 'IsEmpty' over 'Count' to determine whether the object is empty (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1836)