Skip to content

Address code review

b0208b3
Select commit
Loading
Failed to load commit list.
Open

Add Assert.Scope() for soft assertions #7355

Address code review
b0208b3
Select commit
Loading
Failed to load commit list.
Azure Pipelines / microsoft.testfx (Build Linux Debug) failed Feb 9, 2026 in 3m 40s

Build Linux Debug failed

Annotations

Check failure on line 9 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / microsoft.testfx (Build Linux Debug)

Build log #L9

Error: Not found SourceFolder: /mnt/vss/_work/1/s/artifacts/tmp/Debug/testsuite

Check failure on line 60 in src/TestFramework/TestFramework/Assertions/AssertScope.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / microsoft.testfx (Build Linux Debug)

src/TestFramework/TestFramework/Assertions/AssertScope.cs#L60

src/TestFramework/TestFramework/Assertions/AssertScope.cs(60,13): error CA1836: (NETCORE_ENGINEERING_TELEMETRY=Build) Prefer 'IsEmpty' over 'Count' to determine whether the object is empty (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1836)

Check failure on line 4 in src/TestFramework/TestFramework/Assertions/Assert.Scope.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / microsoft.testfx (Build Linux Debug)

src/TestFramework/TestFramework/Assertions/Assert.Scope.cs#L4

src/TestFramework/TestFramework/Assertions/Assert.Scope.cs(4,1): error IDE0005: (NETCORE_ENGINEERING_TELEMETRY=Build) Using directive is unnecessary. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0005)

Check failure on line 4 in src/TestFramework/TestFramework/Assertions/AssertScope.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / microsoft.testfx (Build Linux Debug)

src/TestFramework/TestFramework/Assertions/AssertScope.cs#L4

src/TestFramework/TestFramework/Assertions/AssertScope.cs(4,1): error IDE0005: (NETCORE_ENGINEERING_TELEMETRY=Build) Using directive is unnecessary. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0005)

Check failure on line 60 in src/TestFramework/TestFramework/Assertions/AssertScope.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / microsoft.testfx (Build Linux Debug)

src/TestFramework/TestFramework/Assertions/AssertScope.cs#L60

src/TestFramework/TestFramework/Assertions/AssertScope.cs(60,13): error CA1836: (NETCORE_ENGINEERING_TELEMETRY=Build) Prefer 'IsEmpty' over 'Count' to determine whether the object is empty (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1836)