Skip to content

fix: rename custom events matching browserEventName to use fluent prefix #4609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vnbaaij merged 5 commits into from
Mar 9, 2026
+11 βˆ’11
Merged

fix: rename custom events matching browserEventName to use fluent prefix #4609

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9cca9f4
Initial plan
Copilot Mar 8, 2026
1440fcf
fix: rename custom events matching browserEventName to use fluent prefix
Copilot Mar 8, 2026
de381b1
chore: remove accidentally committed build artifacts
Copilot Mar 8, 2026
5b207b4
chore: remove accidentally committed build artifact and update gitignore
Copilot Mar 8, 2026
f9ed695
revert: undo changes to src/Core.Assets/.gitignore
Copilot Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/Demo/Shared/Pages/HorizontalScroll/Examples/HorizontalScrollDefault.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
ο»Ώ@inject ILogger<HorizontalScrollDefault> logger;

<FluentHorizontalScroll Speed="600" Easing=ScrollEasing.EaseInOut @onscrollstart=OnHorizontalScrollStart @onscrollend=OnHorizontalScrollEnd>
<FluentHorizontalScroll Speed="600" Easing=ScrollEasing.EaseInOut @onfluentscrollstart=OnHorizontalScrollStart @onfluentscrollend=OnHorizontalScrollEnd>
<FluentCard>
Card number 1
<FluentButton Appearance="Appearance.Neutral">A button</FluentButton>
Expand Down
4 changes: 3 additions & 1 deletion src/Core.Assets/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
ο»Ώdist/
ο»Ώdist/
obj/
obj\Debug/
8 changes: 4 additions & 4 deletions src/Core.Assets/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ export function afterStarted(blazor: Blazor, mode: string) {
};
}
});
blazor.registerCustomEventType('scrollstart', {
blazor.registerCustomEventType('fluentscrollstart', {
browserEventName: 'scrollstart',
createEventArgs: event => {
return {
Expand All @@ -321,7 +321,7 @@ export function afterStarted(blazor: Blazor, mode: string) {
}
});

blazor.registerCustomEventType('scrollend', {
blazor.registerCustomEventType('fluentscrollend', {
browserEventName: 'scrollend',
createEventArgs: event => {
return {
Expand All @@ -330,7 +330,7 @@ export function afterStarted(blazor: Blazor, mode: string) {
}
});

blazor.registerCustomEventType('splitterresized', {
blazor.registerCustomEventType('fluentsplitterresized', {
browserEventName: 'splitterresized',
createEventArgs: event => {
return {
Expand All @@ -340,7 +340,7 @@ export function afterStarted(blazor: Blazor, mode: string) {
}
});

blazor.registerCustomEventType('splittercollapsed', {
blazor.registerCustomEventType('fluentsplittercollapsed', {
browserEventName: 'splittercollapsed',
createEventArgs: event => {
return {
Expand Down
4 changes: 2 additions & 2 deletions src/Core/Components/Splitter/FluentSplitter.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
no-barhandle="@(!BarHandle)"
slot1minsize="@Panel1MinSize"
slot2minsize="@Panel2MinSize"
@onsplittercollapsed="OnCollapsedHandler"
@onsplitterresized="OnResizedHandler">
@onfluentsplittercollapsed="OnCollapsedHandler"
@onfluentsplitterresized="OnResizedHandler">
<div slot="1">
@Panel1
</div>
Expand Down
8 changes: 4 additions & 4 deletions src/Core/Events/EventHandlers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@ namespace Microsoft.FluentUI.AspNetCore.Components;
[EventHandler("onaccordionchange", typeof(AccordionChangeEventArgs), enableStopPropagation: true, enablePreventDefault: true)]
[EventHandler("ondialogdismiss", typeof(DialogEventArgs), enableStopPropagation: true, enablePreventDefault: true)]
[EventHandler("onmenuchange", typeof(MenuChangeEventArgs), enableStopPropagation: true, enablePreventDefault: true)]
[EventHandler("onscrollstart", typeof(HorizontalScrollEventArgs), enableStopPropagation: true, enablePreventDefault: true)]
[EventHandler("onscrollend", typeof(HorizontalScrollEventArgs), enableStopPropagation: true, enablePreventDefault: true)]
[EventHandler("onfluentscrollstart", typeof(HorizontalScrollEventArgs), enableStopPropagation: true, enablePreventDefault: true)]
[EventHandler("onfluentscrollend", typeof(HorizontalScrollEventArgs), enableStopPropagation: true, enablePreventDefault: true)]
[EventHandler("onclosecolumnoptions", typeof(EventArgs), enableStopPropagation: true, enablePreventDefault: true)]
[EventHandler("onclosecolumnresize", typeof(EventArgs), enableStopPropagation: true, enablePreventDefault: true)]
[EventHandler("ontooltipdismiss", typeof(EventArgs), enableStopPropagation: true, enablePreventDefault: true)]
[EventHandler("onsplitterresized", typeof(SplitterResizedEventArgs), enableStopPropagation: true, enablePreventDefault: true)]
[EventHandler("onsplittercollapsed", typeof(SplitterCollapsedEventArgs), enableStopPropagation: true, enablePreventDefault: true)]
[EventHandler("onfluentsplitterresized", typeof(SplitterResizedEventArgs), enableStopPropagation: true, enablePreventDefault: true)]
[EventHandler("onfluentsplittercollapsed", typeof(SplitterCollapsedEventArgs), enableStopPropagation: true, enablePreventDefault: true)]
[EventHandler("oncontrolinput", typeof(ChangeEventArgs), enableStopPropagation: true, enablePreventDefault: true)]
[EventHandler("oncomboboxchange", typeof(ChangeEventArgs), enableStopPropagation: true, enablePreventDefault: true)]
public static class EventHandlers
Expand Down
Loading