fix: rename custom events matching browserEventName to use fluent prefix#4609
Merged
fix: rename custom events matching browserEventName to use fluent prefix#4609
Conversation
Co-authored-by: vnbaaij <1761079+vnbaaij@users.noreply.github.com>
Co-authored-by: vnbaaij <1761079+vnbaaij@users.noreply.github.com>
Co-authored-by: vnbaaij <1761079+vnbaaij@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Rename custom events to avoid conflict with browser events
fix: rename custom events matching browserEventName to use fluent prefix
Mar 8, 2026
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 61%
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a .NET 11 runtime exception that occurs when a custom Blazor event registered via blazor.registerCustomEventType() has the same name as its browserEventName. Following the same pattern established in PR #4605 (dateselected → fluentdateselected), four more events are renamed with the fluent prefix while their browserEventName values remain unchanged.
Changes:
- Four custom event type names prefixed with
fluentinindex.tsandEventHandlers.csto fix the .NET 11 conflict (scrollstart,scrollend,splitterresized,splittercollapsed) - Razor directive usages updated in
FluentSplitter.razorand theHorizontalScrollDefault.razordemo example obj/andobj\Debug/patterns added tosrc/Core.Assets/.gitignoreto prevent build artifacts from being tracked
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/Core.Assets/src/index.ts |
Renames 4 registerCustomEventType call names with fluent prefix; browserEventName values unchanged |
src/Core/Events/EventHandlers.cs |
Updates [EventHandler] attributes to match new prefixed event names |
src/Core/Components/Splitter/FluentSplitter.razor |
Updates @on directive usages to @onfluentsplittercollapsed/@onfluentsplitterresized |
examples/Demo/Shared/Pages/HorizontalScroll/Examples/HorizontalScrollDefault.razor |
Updates demo to use @onfluentscrollstart/@onfluentscrollend |
src/Core.Assets/.gitignore |
Adds obj/ patterns to prevent build artifacts from being committed |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Collaborator
|
@copilot do not make any changes to the gitignore file |
Co-authored-by: vnbaaij <1761079+vnbaaij@users.noreply.github.com>
Contributor
Author
vnbaaij
approved these changes
Mar 8, 2026
dvoituron
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
.NET 11 throws a runtime exception when a
blazor.registerCustomEventType()custom event name matches itsbrowserEventName. Following the fix in #4605 (dateselected→fluentdateselected), four more events had the same problem:browserEventNamescrollstartfluentscrollstartscrollstartscrollendfluentscrollendscrollendsplitterresizedfluentsplitterresizedsplitterresizedsplittercollapsedfluentsplittercollapsedsplittercollapsedFiles changed:
src/Core.Assets/src/index.ts— Addedfluentprefix to the 4registerCustomEventTypecall names;browserEventNamevalues are unchanged (they are the actual DOM events fired by the web components)src/Core/Events/EventHandlers.cs— Updated[EventHandler]attribute names accordingly (onscrollstart→onfluentscrollstart, etc.)src/Core/Components/Splitter/FluentSplitter.razor— Updated@onsplitterresized/@onsplittercollapseddirective usagesexamples/.../HorizontalScrollDefault.razor— Updated@onscrollstart/@onscrollenddirective usages in the demo🎫 Issues
👩💻 Reviewer Notes
Straightforward renaming — same pattern as #4605. No behavioral change; only the Blazor event binding names change. Any consumer using
@onscrollstart,@onscrollend,@onsplitterresized, or@onsplittercollapsedin their own Razor files will need to update to thefluent-prefixed names.📑 Test Plan
Verify on .NET 11 Preview that no console exception is thrown when loading pages using
FluentHorizontalScrollorFluentSplitter. Splitter resize/collapse and horizontal scroll start/end callbacks should continue to fire correctly.✅ Checklist
General
Component-specific
⏭ Next Steps
No further events with duplicate names remain in
index.ts.Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.