fix: make McpWorkbench.stop() idempotent instead of raising RuntimeError#7384
Open
SinzoL wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: make McpWorkbench.stop() idempotent instead of raising RuntimeError#7384SinzoL wants to merge 1 commit intomicrosoft:mainfrom
SinzoL wants to merge 1 commit intomicrosoft:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
McpWorkbench.stop() raises RuntimeError when the actor has not been initialized. This is problematic because del calls stop() via asyncio.create_task - if the workbench was never started (or start() failed), the RuntimeError propagates as an unhandled exception in the background task. Make stop() idempotent by silently returning when there is nothing to stop, consistent with DockerCommandLineCodeExecutor.stop(). Fixes #7226