fix: make McpWorkbench.stop() idempotent#7396
Open
Jah-yee wants to merge 3 commits intomicrosoft:mainfrom
Open
fix: make McpWorkbench.stop() idempotent#7396Jah-yee wants to merge 3 commits intomicrosoft:mainfrom
Jah-yee wants to merge 3 commits intomicrosoft:mainfrom
Conversation
When output_dir is None, JupyterCodeExecutor creates a temp directory via tempfile.mkdtemp() but never cleans it up in stop(). This leaks a directory per executor lifetime. Fixes microsoft#7382
…odeExecutor.stop() Fixes microsoft#7383 - Ensures temporary directory cleanup happens after the Docker container is stopped, preventing potential issues with files being deleted while still in use by the container.
- Return early if actor is None instead of raising RuntimeError - This prevents unhandled exceptions when __del__ calls stop() - Consistent with DockerCommandLineCodeExecutor.stop() behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
McpWorkbench.stop()idempotent by returning early if_actorisNoneRuntimeError("McpWorkbench is not started. Call start() first."), it now silently returns__del__callsstop()viaasyncio.create_taskWhy
When the workbench was never started (or
start()failed), theRuntimeErrorpropagates as an unhandled exception in the background task. This is problematic because:__del__can callstop()viaasyncio.create_taskFixes
DockerCommandLineCodeExecutor.stop()behavior