Skip to content

minor typos and force compiler to use C++17 standard only for fmt package #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BogdanGeorgian91 wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −4
Open

minor typos and force compiler to use C++17 standard only for fmt package #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion initBlinkCardReactNativeSample.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ if [ "$IS_LOCAL_BUILD" = true ]; then
else
# Download BlinkCard React Native via NPM
echo "Downloading blinkcard-react-native module"
npm i --save @microblink/blinkcar-react-native
npm i --save @microblink/blinkcard-react-native
fi

# React-native-image-picker plugin needed only for sample application with DirectAPI to get the document images
Expand All @@ -63,6 +63,9 @@ pushd ios || exit 1
# Force minimal iOS version
sed -i '' "s/platform :ios, min_ios_version_supported/platform :ios, '16.0'/" Podfile

# Fix for fmt consteval error in Xcode 16 / newer Clang
perl -i~ -pe "BEGIN{$/ = undef;} s/(react_native_post_install\([^)]+\))/\1\n\n # Fix for fmt consteval error in Xcode 16 \/ newer Clang\n installer.pods_project.targets.each do |target|\n if target.name == 'fmt'\n target.build_configurations.each do |config|\n config.build_settings['CLANG_CXX_LANGUAGE_STANDARD'] = 'c++17'\n end\n end\n end/s" Podfile

# Add the camera and photo usage descriptions into Info.plist to enable camera scanning and the image upload via gallery
sed -i '' '/<dict>/a\
<key>NSCameraUsageDescription</key>\
Expand Down
6 changes: 3 additions & 3 deletions sample_files/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export default function App() {
* Create and modify the liveness settings
*/
const livenessSettings = new LivenessSettings();
livenessSettings.enableCardHelpInHandCheck = true;
livenessSettings.enableCardHeldInHandCheck = true;
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Update README example to the same property name to prevent copy/paste breakage.

The sample now correctly uses enableCardHeldInHandCheck, but the snippet in README.md (lines 1-50 in provided context) still uses enableCardHelpInHandCheck.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@sample_files/App.tsx` at line 88, The README example uses the wrong property
name enableCardHelpInHandCheck which will break copy/paste; update the README
snippet to use the correctly spelled property enableCardHeldInHandCheck (the
same one set in App.tsx) and verify any other examples or docs do not reference
enableCardHelpInHandCheck so examples and runtime code match exactly.

livenessSettings.photocopyCheckStrictnessLevel = StrictnessLevel.Level5;

/**
Expand Down Expand Up @@ -224,7 +224,7 @@ export default function App() {
* Create and modify the liveness settings
*/
const livenessSettings = new LivenessSettings();
livenessSettings.enableCardHelpInHandCheck = true;
livenessSettings.enableCardHeldInHandCheck = true;
livenessSettings.photocopyCheckStrictnessLevel = StrictnessLevel.Level5;

/**
Expand Down Expand Up @@ -334,7 +334,7 @@ export default function App() {
* Create and modify the liveness settings
*/
const livenessSettings = new LivenessSettings();
livenessSettings.enableCardHelpInHandCheck = true;
livenessSettings.enableCardHeldInHandCheck = true;
livenessSettings.photocopyCheckStrictnessLevel = StrictnessLevel.Level5;

/**
Expand Down