minor typos and force compiler to use C++17 standard only for fmt package#20
Open
BogdanGeorgian91 wants to merge 1 commit intomicroblink:mainfrom
Open
minor typos and force compiler to use C++17 standard only for fmt package#20BogdanGeorgian91 wants to merge 1 commit intomicroblink:mainfrom
BogdanGeorgian91 wants to merge 1 commit intomicroblink:mainfrom
Conversation
standard only for fmt package
📝 WalkthroughWalkthroughThe PR corrects the BlinkCard React Native package name from a misspelled variant, adds a Podfile build configuration patch for Clang C++ compatibility, and updates a liveness configuration property name across three scan handlers in the sample application. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
initBlinkCardReactNativeSample.sh (1)
66-68: Fail fast when Podfile patch is not applied.Line 67 can silently no-op if the template changes. Add a post-check so the script exits immediately when the
fmtC++17 override is missing.Suggested hardening
# Fix for fmt consteval error in Xcode 16 / newer Clang perl -i~ -pe "BEGIN{$/ = undef;} s/(react_native_post_install\([^)]+\))/\1\n\n # Fix for fmt consteval error in Xcode 16 \/ newer Clang\n installer.pods_project.targets.each do |target|\n if target.name == 'fmt'\n target.build_configurations.each do |config|\n config.build_settings['CLANG_CXX_LANGUAGE_STANDARD'] = 'c++17'\n end\n end\n end/s" Podfile +grep -q "CLANG_CXX_LANGUAGE_STANDARD.*c++17" Podfile || { + echo "Podfile patch for fmt/C++17 was not applied"; exit 1; +}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@initBlinkCardReactNativeSample.sh` around lines 66 - 68, After applying the perl substitution that inserts the C++17 override inside the Podfile's react_native_post_install block, add a post-check that reads the Podfile and verifies the presence of the inserted block (e.g., that the Podfile now contains the lines referencing target.name == 'fmt' and CLANG_CXX_LANGUAGE_STANDARD = 'c++17'); if the check fails, print an error and exit non‑zero so the script fails fast. Locate the perl insertion around the react_native_post_install(...) pattern and validate the presence of the 'fmt' target override immediately after that substitution, exiting the script when the override is missing.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@sample_files/App.tsx`:
- Line 88: The README example uses the wrong property name
enableCardHelpInHandCheck which will break copy/paste; update the README snippet
to use the correctly spelled property enableCardHeldInHandCheck (the same one
set in App.tsx) and verify any other examples or docs do not reference
enableCardHelpInHandCheck so examples and runtime code match exactly.
---
Nitpick comments:
In `@initBlinkCardReactNativeSample.sh`:
- Around line 66-68: After applying the perl substitution that inserts the C++17
override inside the Podfile's react_native_post_install block, add a post-check
that reads the Podfile and verifies the presence of the inserted block (e.g.,
that the Podfile now contains the lines referencing target.name == 'fmt' and
CLANG_CXX_LANGUAGE_STANDARD = 'c++17'); if the check fails, print an error and
exit non‑zero so the script fails fast. Locate the perl insertion around the
react_native_post_install(...) pattern and validate the presence of the 'fmt'
target override immediately after that substitution, exiting the script when the
override is missing.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 184a7216-1f52-4cf9-a1b5-3c6395b873d8
📒 Files selected for processing (2)
initBlinkCardReactNativeSample.shsample_files/App.tsx
| */ | ||
| const livenessSettings = new LivenessSettings(); | ||
| livenessSettings.enableCardHelpInHandCheck = true; | ||
| livenessSettings.enableCardHeldInHandCheck = true; |
There was a problem hiding this comment.
Update README example to the same property name to prevent copy/paste breakage.
The sample now correctly uses enableCardHeldInHandCheck, but the snippet in README.md (lines 1-50 in provided context) still uses enableCardHelpInHandCheck.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@sample_files/App.tsx` at line 88, The README example uses the wrong property
name enableCardHelpInHandCheck which will break copy/paste; update the README
snippet to use the correctly spelled property enableCardHeldInHandCheck (the
same one set in App.tsx) and verify any other examples or docs do not reference
enableCardHelpInHandCheck so examples and runtime code match exactly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was curios to give it a spin and found some minor typos and a compiler issue :)
Summary by CodeRabbit