Skip to content

fn parse_obus: fix type of payload_size #1478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thedataking merged 1 commit into from
Mar 18, 2026
Merged

fn parse_obus: fix type of payload_size #1478

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/obu.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2391,7 +2391,7 @@ fn parse_obus(
})); // TODO(kkysen) fallible allocation
}
Some(ObuMetaType::ItutT35) => {
let mut payload_size = gb.remaining_len();
let mut payload_size = gb.remaining_len() as isize;
// Don't take into account all the trailing bits for `payload_size`.
while payload_size > 0 && gb[payload_size as usize - 1] == 0 {
payload_size -= 1; // trailing_zero_bit x 8
Expand All @@ -2406,7 +2406,7 @@ fn parse_obus(
payload_size -= 1;
}

if payload_size == 0 || gb[payload_size] != 0x80 {
if payload_size <= 0 || gb[payload_size as usize] != 0x80 {
writeln!(c.logger, "Malformed ITU-T T.35 metadata message format");
} else {
let country_code = country_code as u8;
Expand Down
Loading