Skip to content

fn parse_obus: fix type of payload_size#1478

Merged
thedataking merged 1 commit intomainfrom
perl/fix_1476
Mar 18, 2026
Merged

fn parse_obus: fix type of payload_size#1478
thedataking merged 1 commit intomainfrom
perl/fix_1476

Conversation

@thedataking
Copy link
Collaborator

@thedataking thedataking commented Mar 18, 2026 •
edited by kkysen
Loading

@thedataking thedataking marked this pull request as draft March 18, 2026 08:04
@thedataking thedataking requested a review from kkysen March 18, 2026 11:05
@thedataking thedataking marked this pull request as ready for review March 18, 2026 11:06
@kkysen kkysen changed the title Fix type of payload_size in parse_obus fn parse_obus: fix type of payload_size Mar 18, 2026
kkysen
kkysen approved these changes Mar 18, 2026
View reviewed changes
Copy link
Collaborator

@kkysen kkysen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit about the type annotation.

@thedataking
Fix ITUT T.35 payload_size underflow
df41b67 
A local variable was typed as a `usize` where dav1d uses `ptrdiff_t`
which lead to downstream differences in the validation logic.

Closes #1476. Thanks to @Shnatsel for finding this issue through fuzz
testing.
@thedataking thedataking merged commit 9d78516 into main Mar 18, 2026
28 checks passed
@thedataking thedataking deleted the perl/fix_1476 branch March 18, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kkysen kkysen kkysen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Panic on malformed input in getbits.rs: range end index 18446744073709551615 out of range for slice of length 3

2 participants

@thedataking @kkysen