ffi: use fork of tracing crate with a fix for Android logs rotation#4038
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4038 +/- ##
==========================================
+ Coverage 84.50% 84.51% +0.01%
==========================================
Files 266 266
Lines 28475 28475
==========================================
+ Hits 24062 24066 +4
+ Misses 4413 4409 -4 ☔ View full report in Codecov by Sentry. |
poljar
left a comment
There was a problem hiding this comment.
Please use the patch section for this like we already do for some other things:
Lines 122 to 124 in 322c5b3
Since this is only needed for the bindings, there's no need to change the dependency definition. This way we'll be able to publish releases, while Android and the bindings, which don't need to be published on crates.io, can use the fork.
|
I think it should be ok after e7f5135 |
| tracing-core = { git = "https://github.com/element-hq/tracing.git", rev = "ca9431f74d37c9d3b5e6a9f35b2c706711dab7dd" } | ||
| tracing-subscriber = { git = "https://github.com/element-hq/tracing.git", rev = "ca9431f74d37c9d3b5e6a9f35b2c706711dab7dd" } | ||
| tracing-appender = { git = "https://github.com/element-hq/tracing.git", rev = "ca9431f74d37c9d3b5e6a9f35b2c706711dab7dd" } | ||
| paranoid-android = { git = "https://github.com/element-hq/paranoid-android.git", rev = "69388ac5b4afeed7be4401c70ce17f6d9a2cf19b" } No newline at end of file |
There was a problem hiding this comment.
There's a newline missing here at the end.
e7f5135 to
10a0b7e
Compare
The
tracinglibrary has an issue that prevents the configured log rotation from working on Android. While there has been a proposed fix for some time, it hasn't been merged yet.We recently discovered some cases of users who had hundreds of log files, several times our current max limit, and today I confirmed old logs weren't being deleted.
My proposed solution is to use a forked tracing library in the meantime, along with a forked paranoid-android one, which needs to use this former fork.
I tested this on an Android client and I saw the old logs being removed, as expected.
Signed-off-by: