ffi: move the dependency override from ffi/Cargo.toml to the root one#4044
Merged
jmartinesp merged 1 commit intomainfrom Sep 30, 2024
Merged
ffi: move the dependency override from ffi/Cargo.toml to the root one#4044jmartinesp merged 1 commit intomainfrom
ffi/Cargo.toml to the root one#4044jmartinesp merged 1 commit intomainfrom
Conversation
This seems to be the only way to make the log rotation fix work and avoid build warnings like:
```
warning: patch for the non root package will be ignored, specify patch at the workspace root:
package: matrix-rust-sdk/bindings/matrix-sdk-ffi/Cargo.toml
workspace: = matrix-rust-sdk/Cargo.toml
Finished `dev` profile [unoptimized] target(s) in 0.30s
```
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4044 +/- ##
==========================================
+ Coverage 84.50% 84.51% +0.01%
==========================================
Files 266 266
Lines 28512 28512
==========================================
+ Hits 24093 24098 +5
+ Misses 4419 4414 -5 ☔ View full report in Codecov by Sentry. |
poljar
approved these changes
Sep 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to be the only way to make the log rotation fix work and avoid build warnings like:
I can confirm log rotation was working fine on an Android client after these changes, while it's not working with the current code on
main.Fixes the implementation in #4038.
Signed-off-by: