Skip to content

chore: use --match 'v*' in git describe to ignore submodule tags #2037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jtobin wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

chore: use --match 'v*' in git describe to ignore submodule tags #2037

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ MIGRATE_BIN := $(GO_BIN)/migrate
# VERSION_GO_FILE is the golang file which defines the current project version.
VERSION_GO_FILE := "version.go"

COMMIT := $(shell git describe --tags --dirty --always)
COMMIT := $(shell git describe --tags --match 'v*' --dirty --always)

GOBUILD := go build -v
GOINSTALL := go install -v
Expand Down
2 changes: 1 addition & 1 deletion scripts/release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ function check_tag_correct() {
fi

# If a tag is specified, ensure that that tag is present and checked out.
if [[ $tag != $(git describe --tags) ]]; then
if [[ $tag != $(git describe --tags --match 'v*') ]]; then
red "tag $tag not checked out"
exit 1
else
Expand Down