chore: use --match 'v*' in git describe to ignore submodule tags#2037
chore: use --match 'v*' in git describe to ignore submodule tags#2037jtobin wants to merge 1 commit intolightninglabs:mainfrom
Conversation
When a commit has both a release tag (e.g. v0.7.2) and a Go submodule tag (e.g. taprpc/v1.0.13), git describe --tags may return the submodule tag, causing 1) the submodule tag to be baked as the version string into any locally-built binary, and 2) the release build to fail with the "tag not checked out" error. The use of "--match 'v*'" fixes the issue by ensuring that 'git describe' only hits an actual release tag.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates git describe commands in the Makefile and scripts/release.sh to include the --match 'v*' flag. This ensures that only release tags, which are prefixed with 'v', are considered for version string generation, thereby ignoring submodule tags. The changes are consistent across both files and effectively address the versioning and release build issues described. I have reviewed the changes and have no further feedback.
|
@GeorgeTsagk: review reminder |
3 participants
When a commit has both a release tag (e.g. v0.7.0) and a Go submodule tag (e.g. taprpc/v1.0.13), git describe --tags may return the submodule tag, causing 1) the submodule tag to be baked as the version string into any locally-built binary (e.g. taprpc/v1.0.13-445-g4f622253), and 2) the release build to fail with the "tag not checked out" error.
The use of "--match 'v*'" fixes the issue by ensuring that 'git describe' only hits an actual release tag (so we get e.g. v0.7.0-445-g4f622253 instead, and the release build works).