BE: issues/711: Normalize path for proto schemas locations for Windows OS#712
BE: issues/711: Normalize path for proto schemas locations for Windows OS#712DimaVilda wants to merge 2 commits intokafbat:mainfrom
Conversation
|
hey peeps! I created a MR to their source code to fix their issue and described a problem. Check: Hope they will merge it and we can pull it up later. However I am not sure we can do it pretty soon. |
| String relativePath = baseLocation.relativize(path).toString(); | ||
| var protoFileElement = ProtoParser.Companion.parse( | ||
| Location.get(baseLocation.toString(), relativePath), | ||
| Location.get( |
There was a problem hiding this comment.
Hi, thanks for the PR.
This is what I meant in #696 (comment). This feels like a hacky solution aiming to fix the tests on Windows. In the end, there are built-in APIs in io/nio that we'd like to use if there's a need.
it's been discussed here before: #261 (comment)
Considering this is a bug in wire, I'd wait for it to get fixed so we don't have to resort to such solutions.
Let me know what you think
There was a problem hiding this comment.
Sure, we can wait for some fix from 'wire' side and I understnand that it looks hacky, that is why I higlighted this approach as tempo in comments. Feel free to close it.
What changes did you make? (Give an overview)
A change is related to #711 issue.
Problem:
Solution:
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)