Skip to content

bmcweb: Remove size limit for dump offloads #1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhilashraju wants to merge 1 commit into
base: 1120
Choose a base branch
from
+4 −2
Open

bmcweb: Remove size limit for dump offloads #1384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions redfish-core/lib/log_services.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,8 +617,10 @@ inline bool checkSizeLimit(int fd, crow::Response& res)
{
BMCWEB_LOG_ERROR("File size {} exceeds maximum allowed size of {}",
size, maxFileSize);
messages::internalError(res);
return false;
// let the offload continue even if size limit is crossed
Copy link
Copy Markdown
Contributor

@gtmills gtmills Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's increase the size above if we need this. Let's not have no size at all.

// let the dealine timer take care of cancelling the offload.
// messages::internalError(res);
// return false;
}
off_t rc = lseek(fd, 0, SEEK_SET);
if (rc < 0)
Expand Down