bmcweb: Remove size limit for dump offloads#1384
Open
abhilashraju wants to merge 1 commit intoibm-openbmc:1120from
Open
bmcweb: Remove size limit for dump offloads#1384abhilashraju wants to merge 1 commit intoibm-openbmc:1120from
abhilashraju wants to merge 1 commit intoibm-openbmc:1120from
Conversation
Currently, a hardcoded size limit of 20MB exists for BMC and resource dumps during offloading. This presents a limitation as dump sizes are increasing with new feature additions. This change removes the size check in `checkSizeLimit` to allow larger dumps to be offloaded. The existing deadline timer for the offload operation is sufficient to handle cases where the dump generation takes too long, making the size check redundant. This allows the BMC to offload as much of the dump as possible within the configured time limit. Signed-off-by: Abhilash Raju <abhilash.kollam@gmail.com>
Contributor
|
Should this be discussed and handled from upstream? |
gtmills
reviewed
Dec 5, 2025
| size, maxFileSize); | ||
| messages::internalError(res); | ||
| return false; | ||
| // let the offload continue even if size limit is crossed |
Contributor
There was a problem hiding this comment.
Let's increase the size above if we need this. Let's not have no size at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, a hardcoded size limit of 20MB exists for BMC and resource dumps during offloading. This presents a limitation as dump sizes are increasing with new feature additions.
This change removes the size check in
checkSizeLimitto allow larger dumps to be offloaded. The existing deadline timer for the offload operation is sufficient to handle cases where the dump generation takes too long, making the size check redundant.This allows the BMC to offload as much of the dump as possible within the configured time limit.