Skip to content

1110: Add log traces when subscription is added/deleted #1376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
baemyung wants to merge 1 commit into
base: 1110
Choose a base branch
from
Open

1110: Add log traces when subscription is added/deleted #1376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions redfish-core/include/event_service_manager.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ class EventServiceManager
};

subscriptionsMap.emplace(id, subValue);
BMCWEB_LOG_ERROR("Subscription ID: {} is loaded", id);

updateNoOfSubscribersCount();

Expand Down Expand Up @@ -443,6 +444,7 @@ class EventServiceManager
auto inserted = subscriptionsMap.insert(std::pair(id, subValue));
if (inserted.second)
{
BMCWEB_LOG_ERROR("Subscription ID: {} is added", id);
break;
}
--retry;
Expand Down Expand Up @@ -540,6 +542,7 @@ class EventServiceManager
BMCWEB_LOG_ERROR("Subscription {} wasn't in persistent data", id);
return true;
}
BMCWEB_LOG_ERROR("Subscription ID: {} is deleted", id);
persistent_data::EventServiceStore::getInstance()
.subscriptionsConfigMap.erase(persistentObj);
updateNoOfSubscribersCount();
Expand Down
5 changes: 3 additions & 2 deletions redfish-core/src/subscription.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,9 @@ void Subscription::resHandler(const std::shared_ptr<Subscription>& /*self*/,
hbTimer.cancel();
if (deleter)
{
BMCWEB_LOG_INFO("Subscription {} is deleted after MaxRetryAttempts",
userSub->id);
BMCWEB_LOG_ERROR(
"Subscription {} is deleted after MaxRetryAttempts",
userSub->id);
deleter();
}
}
Expand Down