1110: Add log traces when subscription is added/deleted#1376
Open
baemyung wants to merge 1 commit intoibm-openbmc:1110from
Open
1110: Add log traces when subscription is added/deleted#1376baemyung wants to merge 1 commit intoibm-openbmc:1110from
baemyung wants to merge 1 commit intoibm-openbmc:1110from
Conversation
b752d37 to
e18cbfd
Compare
Contributor
Author
e18cbfd to
174c444
Compare
Contributor
Author
|
I pushed this again so that it can be built on top of fw1110.02-1 image. |
While debugging the subscription history related to the code update, it would be easier to find where/when the subscription may be removed. - Register a new subscription ``` Oct 24 19:11:21 p11bmc bmcweb[1839]: [ERROR event_service_manager.hpp:447] Subscription ID: 3622702393 is added ``` - A subscription is deleted ``` Oct 24 19:12:13 p11bmc bmcweb[1839]: [ERROR event_service_manager.hpp:545] Subscription ID: 3437703746 is deleted ``` - Restart bmcweb & check whether the persistent subscriptions ``` Oct 24 19:12:19 p11bmc systemd[1]: Stopping Start bmcweb server... Oct 24 19:12:19 p11bmc systemd[1]: bmcweb.service: Deactivated successfully. Oct 24 19:12:19 p11bmc systemd[1]: Stopped Start bmcweb server. Oct 24 19:12:21 p11bmc systemd[1]: Started Start bmcweb server. Oct 24 19:12:21 p11bmc bmcweb[1871]: [ERROR event_service_manager.hpp:144] Subscription ID: 3622702393 is loaded ``` Note: If the subscription is deleted due to the max retry, it may look like ``` Oct 24 18:53:19 p11bmc bmcweb[1579]: [ERROR http_client.hpp:445] Maximum number of retries reached. https://9.10.239.119:8080/Test-Redfish-Event-Listener Oct 24 18:53:19 p11bmc bmcweb[1579]: [ERROR subscription.cpp:102] Subscription 4212505157 is deleted after MaxRetryAttempts Oct 24 18:53:19 p11bmc bmcweb[1579]: [ERROR event_service_manager.hpp:545] Subscription ID: 4212505157 is deleted ``` Signed-off-by: Myung Bae <myungbae@us.ibm.com>
174c444 to
8f1f9c0
Compare
jeaaustx
approved these changes
Nov 3, 2025
Contributor
jeaaustx
left a comment
There was a problem hiding this comment.
Looks good to me.
Seems like it would be nice to have an extra layer of bmcweb-logging between error and warning for these types of things we want to log by default but don't want to confuse by having it show as an error in the log. (But that is something for another day...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While debugging the subscription history related to the code update, it would be easier to find where/when the subscription may be removed.
Note:
If the subscription is deleted due to the max retry, it may look like