Skip to content

update scalar-time-chart.js to d3js v4 API #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vizvamitra wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update scalar-time-chart.js to d3js v4 API #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 9 additions & 14 deletions static/js/lib/utils/scalar-time-chart.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ $(function() {

InputChart.prototype.loadData = function(callback) {
var me = this;
var parseDate = d3.time.format("%m/%d/%y %H:%M").parse;
var parseDate = d3.timeParse("%m/%d/%y %H:%M");
if (! me.data) {
d3.csv(me.csv, function (error, data) {
if (error) return callback(error);
Expand All @@ -65,24 +65,19 @@ $(function() {
$(this.selector).html('');
this.dataCursor = 0;

this.transformDateIntoXValue = d3.time.scale()
this.transformDateIntoXValue = d3.scaleTime()
.range([0, width]);

var y = d3.scale.linear()
var y = d3.scaleLinear()
.range([height, 0]);

var color = d3.scale.category10();
var color = d3.scaleOrdinal(d3.schemeCategory10);

var xAxis = d3.svg.axis()
.scale(me.transformDateIntoXValue)
.orient("bottom");
var xAxis = d3.axisBottom(me.transformDateIntoXValue)
var yAxis = d3.axisLeft(y)

var yAxis = d3.svg.axis()
.scale(y)
.orient("left");

var line = d3.svg.line()
.interpolate("basis")
var line = d3.line()
.curve(d3.curveBasis)
.x(function (d) {
return me.transformDateIntoXValue(d.date);
})
Expand Down Expand Up @@ -276,4 +271,4 @@ $(function() {
window.HTM.utils.chart = {
InputChart: InputChart
};
});
});