update scalar-time-chart.js to d3js v4 API#32
Open
vizvamitra wants to merge 1 commit intohtm-community:masterfrom
Open
update scalar-time-chart.js to d3js v4 API#32vizvamitra wants to merge 1 commit intohtm-community:masterfrom
vizvamitra wants to merge 1 commit intohtm-community:masterfrom
Conversation
Collaborator
|
Holy cow thank you! I will review this this coming week during one of my Twitch work sessions. |
|
I just downgraded to d3 v3 because of ep7 onward not properly working. An upgrade might be appropriate since d3 v5.11 is out there already. |
Collaborator
|
Thank you for the nudge. I've added this to my agenda. Planning some new visualizations soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ep7/Random SP was not working because
scalar-time-chart.jswas using old d3 V3 API (addressed earlier in #31).I've updated the code that was causing errors according to d3js changelog, yet i'm not sure if I've updated everything.
At least episode 7 now seems to work ^_^