Drop support for anything below GHC 8.0.0, base 4.9.0.0, Cabal 2.0.0.0#11630
Drop support for anything below GHC 8.0.0, base 4.9.0.0, Cabal 2.0.0.0#11630zlonast wants to merge 1 commit intohaskell:masterfrom
Conversation
|
Should we drop compilers below 8.6? Or 8.8? |
zlonast
force-pushed
the
zlonast/old-mkVersion
branch
3 times, most recently
from
1cd54e4 to
27e6671
Compare
|
This does modify behaviour, does it not? |
zlonast
force-pushed
the
zlonast/old-mkVersion
branch
2 times, most recently
from
9f262e4 to
2547133
Compare
|
@ffaf1 It seems to me that if I can't compile the code with an old compiler, then this doesn't count as a change in behavior. |
Makes sense! |
zlonast
force-pushed
the
zlonast/old-mkVersion
branch
from
314c399 to
ca8e7bb
Compare
zlonast
changed the title
zlonast
force-pushed
the
zlonast/old-mkVersion
branch
from
9e5e88e to
f0bc384
Compare
zlonast
force-pushed
the
zlonast/old-mkVersion
branch
from
fce4414 to
3b62aac
Compare
🤔 |
zlonast
changed the title
Mikolaj
left a comment
Mikolaj
left a comment
There was a problem hiding this comment.
I seem there are still review comments to be addressed so it may need some more work in general I love the idea and removing code is good. Thank you!
|
@zlonast could you please rebase? |
zlonast
force-pushed
the
zlonast/old-mkVersion
branch
2 times, most recently
from
4e0b01a to
39ff388
Compare
zlonast
force-pushed
the
zlonast/old-mkVersion
branch
from
39ff388 to
5107892
Compare
| | isGHC, compVer >= mkVersion [8, 0] = mkVersion [1, 24] | ||
| | isGHC, compVer >= mkVersion [7, 10] = mkVersion [1, 22] | ||
| | otherwise = mkVersion [1, 20] | ||
| | otherwise = mkVersion [2, 0] |
There was a problem hiding this comment.
This seemingly drops support of GHC 8.0 as well?.. Could we keep it for now?
There was a problem hiding this comment.
No, it's suggested to drop cabal 1.24
| , flagDebugInfo = v >= [7, 10] | ||
| , flagHie = v >= [8, 8] | ||
| , supportsDebugLevels = v >= [8, 0] | ||
| , supportsPkgEnvFiles = v >= [8, 0, 1, 20160901] -- broken in 8.0.1, fixed in 8.0.2 |
There was a problem hiding this comment.
This one is probably worth keeping for now, until we decide to drop GHC 8.0 entirely.
There was a problem hiding this comment.
I think supporting non-major versions is not a very good practice?
zlonast
force-pushed
the
zlonast/old-mkVersion
branch
from
5107892 to
e2aa9e9
Compare
5 participants
We don't have any testing for such old versions of ghc. Since this code isn't used, I assume it doesn't work, but it's difficult to confirm otherwise.
We just dropped everything below (ghc 8.0.0, base 4.9.0.0, cabal 2.0.0.0)
Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
significance: significantin the changelog file.