Skip to content

Handle removing files better#11616

Merged
mergify[bot] merged 2 commits intomasterfrom
removeFileForcibly
Mar 24, 2026
Merged

Handle removing files better#11616
mergify[bot] merged 2 commits intomasterfrom
removeFileForcibly

Conversation

@Bodigrim
Copy link
Copy Markdown
Collaborator

@Bodigrim Bodigrim commented Mar 14, 2026

Closes #11606.

Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:

@Bodigrim Bodigrim force-pushed the removeFileForcibly branch from 0ec2a49 to 4accda8 Compare March 14, 2026 15:16
Copy link
Copy Markdown
Collaborator

@zlonast zlonast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I like this pull request, just like renameFileWithRetry. But it doesn't prevent the silent death of the build on Windows.

@Bodigrim
Copy link
Copy Markdown
Collaborator Author

Anyone else up for review please?

Copy link
Copy Markdown
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Bodigrim Bodigrim force-pushed the removeFileForcibly branch from 326631c to e537ce0 Compare March 22, 2026 15:08
@Bodigrim Bodigrim added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Mar 22, 2026
@mergify mergify bot added ready and waiting Mergify is waiting out the cooldown period merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days queued labels Mar 22, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 24, 2026

Merge Queue Status

This pull request spent 1 hour 57 minutes 32 seconds in the queue, including 1 hour 45 minutes 47 seconds running CI.

Required conditions to merge
  • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Doctest Cabal
    • check-neutral = Doctest Cabal
    • check-skipped = Doctest Cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Meta checks
    • check-neutral = Meta checks
    • check-skipped = Meta checks
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:cabal
    • check-neutral = docs/readthedocs.org:cabal
    • check-skipped = docs/readthedocs.org:cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Validate post job
    • check-neutral = Validate post job
    • check-skipped = Validate post job
  • any of [🛡 GitHub branch protection]:
    • check-success = fourmolu
    • check-neutral = fourmolu
    • check-skipped = fourmolu
  • any of [🛡 GitHub branch protection]:
    • check-success = hlint
    • check-neutral = hlint
    • check-skipped = hlint
  • any of [🛡 GitHub branch protection]:
    • check-success = Bootstrap post job
    • check-neutral = Bootstrap post job
    • check-skipped = Bootstrap post job
  • any of [🛡 GitHub branch protection]:
    • check-success = whitespace
    • check-neutral = whitespace
    • check-skipped = whitespace
  • any of [🛡 GitHub branch protection]:
    • check-success = Check sdist post job
    • check-neutral = Check sdist post job
    • check-skipped = Check sdist post job
  • any of [🛡 GitHub branch protection]:
    • check-success = Changelogs
    • check-neutral = Changelogs
    • check-skipped = Changelogs

mergify bot added a commit that referenced this pull request Mar 24, 2026
mergify bot added a commit that referenced this pull request Mar 24, 2026
@mergify mergify bot merged commit 92c28e2 into master Mar 24, 2026
208 of 210 checks passed
@mergify mergify bot deleted the removeFileForcibly branch March 24, 2026 18:56
@mergify mergify bot removed the queued label Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle removing files better

4 participants