Return status codes from ShowChronicles and ShowStories#639
Draft
Return status codes from ShowChronicles and ShowStories#639
Conversation
Both APIs returned vector<string>& with no status, so callers couldn't distinguish between "no results", "unauthorized", and "RPC failure". Switch the public client API, the Visor portal, and the Thallium RPC to return int with the result vector as an out-parameter, matching the rest of the metadata API. Also wire the authorization predicate on ShowChronicles (was a TODO) and propagate the existing ChronicleMetaDirectory return codes that were being dropped on the floor. Closes #576.
iameneko
added
ChronoVisor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both APIs returned a vector reference with no way to tell apart no-results, unauthorized, and RPC failure — they all surfaced as an empty list, which is also why the Python binding skipped them. Switches the public client API, the Visor portal, and the Thallium RPC over to returning int with the result vector as an out-parameter, matching the rest of the metadata API. Also wires the authorization predicate on ShowChronicles (was a TODO) and propagates the ChronicleMetaDirectory return codes that were being dropped on the floor.
Closes #576. Part of #572.