Expose chronicle metadata APIs in Python and CLI#643
Draft
iameneko wants to merge 1 commit into
Draft
Conversation
Adds Python bindings for GetChronicleAttr, EditChronicleAttr, ShowChronicles and ShowStories — the four metadata APIs the C++ client and Visor have always implemented but py_chronolog_client never bound, so Python callers had no way to list chronicles or inspect their attributes. The two Show* bindings return (rc, list) tuples and GetChronicleAttr returns (rc, value), matching the out-parameter shape of the underlying C++ API. Also adds matching interactive commands to client_cli (-l -c, -l -s, -g, -e), and deletes the long-commented-out Local* stub block in VisorClientPortal.cpp that has been dead since the API was redesigned. Closes #573.
iameneko
added
ChronoVisor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Python bindings for GetChronicleAttr, EditChronicleAttr, ShowChronicles and ShowStories — the four metadata APIs the C++ client and Visor have always implemented but py_chronolog_client never bound, so Python callers had no way to list chronicles or inspect their attributes. The two Show* bindings return (rc, list) tuples and GetChronicleAttr returns (rc, value), matching the out-parameter shape of the underlying C++ API.
Also adds matching interactive commands to client_cli (-l -c, -l -s, -g, -e), and deletes the long-commented-out Local* stub block in VisorClientPortal.cpp that has been dead since the API was redesigned.
Stacked on #639 (the new ShowChronicles / ShowStories signatures land there). Will be retargeted to develop once #639 merges.
Closes #573. Part of #572.