Skip to content

fix(storage): test_transfer_manager counts unwanted deprecated warnings #16744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
parthea merged 2 commits into from
Apr 21, 2026
+13 −4
Merged

fix(storage): test_transfer_manager counts unwanted deprecated warnings #16744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8741b0b
fix: test_transfer_manager counts unwanted deprecated warnings
nidhiii-27 Apr 21, 2026
db61693
update error message
nidhiii-27 Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/google-cloud-storage/tests/unit/test_fileio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -922,8 +922,8 @@ def test_write(self, mock_warn):

# The transmit_next_chunk method must actually consume bytes from the
# sliding buffer for the flush() feature to work properly.
upload.transmit_next_chunk.side_effect = (
lambda _: unwrapped_writer._buffer.read(chunk_size)
upload.transmit_next_chunk.side_effect = lambda _: (
unwrapped_writer._buffer.read(chunk_size)
)

# Write under chunk_size. This should be buffered and the upload not
Expand Down
13 changes: 11 additions & 2 deletions packages/google-cloud-storage/tests/unit/test_transfer_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,8 +556,17 @@ def test_download_many_to_path_raises_invalid_path_error():
skip_if_exists=True,
)

assert len(w) == 1
assert "will **NOT** be downloaded" in str(w[0].message)
invalid_path_warnings = [
warning
for warning in w
if str(warning.message).startswith("The blob ")
and "will **NOT** be downloaded" in str(warning.message)
]

assert len(invalid_path_warnings) == 1, (
f"Expected 1 invalid path warning, found {len(invalid_path_warnings)}. All warnings: {[str(warning.message) for warning in w]}"
)
Comment thread
nidhiii-27 marked this conversation as resolved.

assert len(results) == 1
assert isinstance(results[0], UserWarning)

Expand Down
Loading