fix(storage): test_transfer_manager counts unwanted deprecated warnings#16744
Merged
fix(storage): test_transfer_manager counts unwanted deprecated warnings#16744
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates unit tests for the google-cloud-storage package. In test_fileio.py, a lambda expression was reformatted for clarity. In test_transfer_manager.py, the logic for asserting warnings was improved to filter for specific messages and provide more context upon failure. A review comment suggests further enhancing the assertion message in test_transfer_manager.py by explicitly including the expected versus actual count of matching warnings to aid in debugging.
nidhiii-27
changed the title
parthea
approved these changes
Apr 21, 2026
chandra-siri
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_transfer_manager::test_download_many_to_path_raises_invalid_path_error catches all types of warnings (including FutureWarnings and DeprecationWarnings) whereas it is only required to check invalid path warnings.
Fixed the test to only include invalid_path_warnings