Skip to content

fix(osx): use console owner instead of $USER in postinstall script #2279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(osx): use console owner instead of $USER in postinstall script #2279

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
618e259
Initial plan
Copilot Mar 4, 2026
1832f58
fix(osx): use stat -f%Su /dev/console to determine real user in posti…
Copilot Mar 4, 2026
66ac576
fix(osx): handle headless/SSH installs in postinstall with SUDO_USER …
Copilot Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/osx/Installer.Mac/scripts/postinstall
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,10 @@ mkdir -p /usr/local/bin
/bin/ln -Fs "$INSTALL_DESTINATION/git-credential-manager" /usr/local/bin/git-credential-manager

# Configure GCM for the current user (running as the current user to avoid root
# from taking ownership of ~/.gitconfig)
sudo -u ${USER} "$INSTALL_DESTINATION/git-credential-manager" configure
# from taking ownership of ~/.gitconfig).
# Use stat to determine the console user since the installer may be invoked with
# USER unset (e.g. when run via Homebrew which explicitly clears USER).
REAL_USER=$(stat -f%Su /dev/console)
Copy link
Contributor

@mjcheetham mjcheetham Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if someone is installing GCM (either via Homebrew or the installer command line) from an SSH session where there is no console user? We need to make sure this works for remote/multi-user scenarios.

sudo -u "${REAL_USER}" "$INSTALL_DESTINATION/git-credential-manager" configure

exit 0
Loading