Skip to content

fix(osx): use console owner instead of $USER in postinstall script #2279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(osx): use console owner instead of $USER in postinstall script #2279

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
618e259
Initial plan
Copilot Mar 4, 2026
1832f58
fix(osx): use stat -f%Su /dev/console to determine real user in posti…
Copilot Mar 4, 2026
66ac576
fix(osx): handle headless/SSH installs in postinstall with SUDO_USER …
Copilot Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions src/osx/Installer.Mac/scripts/postinstall
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,22 @@ mkdir -p /usr/local/bin
/bin/ln -Fs "$INSTALL_DESTINATION/git-credential-manager" /usr/local/bin/git-credential-manager

# Configure GCM for the current user (running as the current user to avoid root
# from taking ownership of ~/.gitconfig)
sudo -u ${USER} "$INSTALL_DESTINATION/git-credential-manager" configure
# from taking ownership of ~/.gitconfig).
# Determine the real (non-root) user via multiple methods since the installer
# may be invoked with USER/LOGNAME unset (e.g. when run via Homebrew which
# explicitly clears those environment variables).
# 1. SUDO_USER - set by sudo, works for both GUI (Homebrew) and SSH scenarios.
# 2. stat /dev/console - works for GUI sessions when not running under sudo.
REAL_USER="${SUDO_USER}"
if [ -z "${REAL_USER}" ] || [ "${REAL_USER}" = "root" ]; then
REAL_USER=$(stat -f%Su /dev/console 2>/dev/null)
fi

if [ -n "${REAL_USER}" ] && [ "${REAL_USER}" != "root" ]; then
sudo -u "${REAL_USER}" "$INSTALL_DESTINATION/git-credential-manager" configure
else
echo "warning: unable to determine the installing user; GCM has not been configured automatically." >&2
echo "warning: run 'git-credential-manager configure' to configure GCM for your user." >&2
fi

exit 0
Loading