Skip to content

ref: Add span filtering to span first (15) #5633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sentrivana merged 104 commits into from
Mar 12, 2026

3.6

1223f26
Select commit
Loading
Failed to load commit list.
Merged

ref: Add span filtering to span first (15) #5633

3.6
1223f26
Select commit
Loading
Failed to load commit list.
@sentry/warden / warden: find-bugs completed Mar 12, 2026 in 2m 38s

1 issue

find-bugs: Found 1 issue (1 medium)

Medium

Rule with empty attributes dict matches all spans unintentionally - `sentry_sdk/tracing_utils.py:1518-1524`

A span filtering rule like {"attributes": {}} will match ALL spans because the default attributes_match = True is never set to False when iterating over an empty dict. This could cause unintended span dropping if a user accidentally provides an empty attributes dict in their configuration.

Duration: 2m 37s · Tokens: 3.5M in / 20.7k out · Cost: $5.35 (+extraction: $0.00)

Annotations

Check warning on line 1524 in sentry_sdk/tracing_utils.py

See this annotation in the file changed.

@sentry-warden sentry-warden / warden: find-bugs

Rule with empty attributes dict matches all spans unintentionally 

A span filtering rule like `{"attributes": {}}` will match ALL spans because the default `attributes_match = True` is never set to `False` when iterating over an empty dict. This could cause unintended span dropping if a user accidentally provides an empty attributes dict in their configuration.
View more details on @sentry/warden