Skip to content

3.6

1223f26
Select commit
Loading
Failed to load commit list.
Merged

ref: Add span filtering to span first (15) #5633

3.6
1223f26
Select commit
Loading
Failed to load commit list.
@sentry/warden / warden completed Mar 12, 2026 in 4m 26s

1 issue

Medium

Rule with empty attributes dict matches all spans unintentionally - `sentry_sdk/tracing_utils.py:1518-1524`

A span filtering rule like {"attributes": {}} will match ALL spans because the default attributes_match = True is never set to False when iterating over an empty dict. This could cause unintended span dropping if a user accidentally provides an empty attributes dict in their configuration.

4 skills analyzed
Skill Findings Duration Cost
code-review 0 3m 52s $1.55
find-bugs 1 2m 37s $5.35
skill-scanner 0 3m 53s $0.77
security-review 0 4m 21s $1.88

Duration: 14m 43s · Tokens: 5.7M in / 44.3k out · Cost: $9.55 (+extraction: $0.00, +dedup: $0.01)