-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[various] Add unintended_html_in_doc_comment to analysis options
#11303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
stuartmorgan-g
wants to merge
6
commits into
flutter:main
Choose a base branch
from
stuartmorgan-g:unintended-html-analysis
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c9c8779
Add the new analysis options
stuartmorgan-g 166523b
Fix violations
stuartmorgan-g 5ce1825
Version bumps
stuartmorgan-g e07c3a4
Pigeon version bump correction
stuartmorgan-g 8840bb4
Typo
stuartmorgan-g b92282d
Fix violations in tool
stuartmorgan-g File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,15 +8,12 @@ import 'dart:async'; | |
| import 'dart:js_interop'; | ||
| import 'dart:ui'; | ||
|
|
||
| // ignore_for_file: implementation_imports | ||
| import 'package:camera_web/src/camera.dart'; | ||
| import 'package:camera_web/src/camera_service.dart'; | ||
| import 'package:camera_web/src/shims/dart_js_util.dart'; | ||
| import 'package:camera_web/src/types/types.dart'; | ||
| import 'package:mockito/annotations.dart'; | ||
| import 'package:mockito/mockito.dart'; | ||
| // TODO(srujzs): This is exported in `package:web` 0.6.0. Remove this when it is available. | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was just opportunistic cleanup to a test file I was already editing, since I happened to notice it. We already require |
||
| import 'package:web/src/helpers/events/streams.dart'; | ||
| import 'package:web/web.dart' as web; | ||
|
|
||
| @GenerateNiceMocks(<MockSpec<dynamic>>[ | ||
|
|
@@ -80,12 +77,12 @@ class MockScreen { | |
|
|
||
| @JSExport() | ||
| class MockScreenOrientation { | ||
| /// JSPromise<JSAny?> Function(web.OrientationLockType orientation) | ||
| /// `JSPromise<JSAny?> Function(web.OrientationLockType orientation)` | ||
| JSFunction lock = (web.OrientationLockType orientation) { | ||
| return Future<void>.value().toJS; | ||
| }.toJS; | ||
|
|
||
| /// void Function() | ||
| /// `void Function()` | ||
| late JSFunction unlock; | ||
| late web.OrientationType type; | ||
| } | ||
|
|
@@ -97,7 +94,7 @@ class MockDocument { | |
|
|
||
| @JSExport() | ||
| class MockElement { | ||
| /// JSPromise<JSAny?> Function([FullscreenOptions options]) | ||
| /// `JSPromise<JSAny?> Function([FullscreenOptions options])` | ||
| JSFunction requestFullscreen = ([web.FullscreenOptions? options]) { | ||
| return Future<void>.value().toJS; | ||
| }.toJS; | ||
|
|
@@ -110,30 +107,30 @@ class MockNavigator { | |
|
|
||
| @JSExport() | ||
| class MockMediaDevices { | ||
| /// JSPromise<web.MediaStream> Function([web.MediaStreamConstraints? constraints]) | ||
| /// `JSPromise<web.MediaStream> Function([web.MediaStreamConstraints? constraints])` | ||
| late JSFunction getUserMedia; | ||
|
|
||
| /// web.MediaTrackSupportedConstraints Function() | ||
| /// `web.MediaTrackSupportedConstraints Function()` | ||
| late JSFunction getSupportedConstraints; | ||
|
|
||
| /// JSPromise<JSArray<web.MediaDeviceInfo>> Function() | ||
| /// `JSPromise<JSArray<web.MediaDeviceInfo>> Function()` | ||
| late JSFunction enumerateDevices; | ||
| } | ||
|
|
||
| @JSExport() | ||
| class MockMediaStreamTrack { | ||
| /// web.MediaTrackCapabilities Function(); | ||
| /// `web.MediaTrackCapabilities Function()` | ||
| late JSFunction getCapabilities; | ||
|
|
||
| /// web.MediaTrackSettings Function() | ||
| /// `web.MediaTrackSettings Function()` | ||
| JSFunction getSettings = () { | ||
| return web.MediaTrackSettings(); | ||
| }.toJS; | ||
|
|
||
| /// JSPromise<JSAny?> Function([web.MediaTrackConstraints? constraints]) | ||
| /// `JSPromise<JSAny?> Function([web.MediaTrackConstraints? constraints])` | ||
| late JSFunction applyConstraints; | ||
|
|
||
| /// void Function() | ||
| /// `void Function()` | ||
| JSFunction stop = () {}.toJS; | ||
| } | ||
|
|
||
|
|
@@ -145,24 +142,24 @@ class MockVideoElement { | |
|
|
||
| @JSExport() | ||
| class MockMediaRecorder { | ||
| /// void Function(String type, web.EventListener? callback, [JSAny options]) | ||
| /// `void Function(String type, web.EventListener? callback, [JSAny options])` | ||
| JSFunction addEventListener = | ||
| (String type, web.EventListener? callback, [JSAny? options]) {}.toJS; | ||
|
|
||
| /// void Function(String type, web.EventListener? callback, [JSAny options]) | ||
| /// `void Function(String type, web.EventListener? callback, [JSAny options])` | ||
| JSFunction removeEventListener = | ||
| (String type, web.EventListener? callback, [JSAny? options]) {}.toJS; | ||
|
|
||
| /// void Function([int timeslice]) | ||
| /// `void Function([int timeslice])` | ||
| JSFunction start = ([int? timeslice]) {}.toJS; | ||
|
|
||
| /// void Function() | ||
| /// `void Function()` | ||
| JSFunction pause = () {}.toJS; | ||
|
|
||
| /// void Function() | ||
| /// `void Function()` | ||
| JSFunction resume = () {}.toJS; | ||
|
|
||
| /// void Function() | ||
| /// `void Function()` | ||
| JSFunction stop = () {}.toJS; | ||
|
|
||
| web.RecordingState state = 'inactive'; | ||
|
|
@@ -197,9 +194,9 @@ class FakeMediaError { | |
| final String message; | ||
| } | ||
|
|
||
| /// A fake [ElementStream] that listens to the provided [_stream] on [listen]. | ||
| /// A fake [web.ElementStream] that listens to the provided [_stream] on [listen]. | ||
| class FakeElementStream<T extends web.Event> extends Fake | ||
| implements ElementStream<T> { | ||
| implements web.ElementStream<T> { | ||
| FakeElementStream(this._stream); | ||
|
|
||
| final Stream<T> _stream; | ||
|
|
@@ -220,15 +217,15 @@ class FakeElementStream<T extends web.Event> extends Fake | |
| } | ||
| } | ||
|
|
||
| /// A fake [BlobEvent] that returns the provided blob [data]. | ||
| /// A fake [web.BlobEvent] that returns the provided blob [data]. | ||
| @JSExport() | ||
| class FakeBlobEvent { | ||
| FakeBlobEvent(this.data); | ||
|
|
||
| final web.Blob? data; | ||
| } | ||
|
|
||
| /// A fake [DomException] that returns the provided error [_name] and [_message]. | ||
| /// A fake [web.DomException] that returns the provided error [_name] and [_message]. | ||
| @JSExport() | ||
| class FakeErrorEvent { | ||
| FakeErrorEvent(this.type, [this.message = '']); | ||
|
|
@@ -272,7 +269,7 @@ class MockEventStreamProvider<T extends web.Event> extends Mock | |
| } | ||
|
|
||
| @override | ||
| ElementStream<T> forElement(web.Element? e, {bool? useCapture = false}) { | ||
| web.ElementStream<T> forElement(web.Element? e, {bool? useCapture = false}) { | ||
| return super.noSuchMethod( | ||
| Invocation.method( | ||
| #forElement, | ||
|
|
@@ -281,7 +278,7 @@ class MockEventStreamProvider<T extends web.Event> extends Mock | |
| ), | ||
| returnValue: FakeElementStream<T>(Stream<T>.empty()), | ||
| ) | ||
| as ElementStream<T>; | ||
| as web.ElementStream<T>; | ||
| } | ||
| } | ||
|
|
||
|
|
||
4 changes: 4 additions & 0 deletions
4
packages/in_app_purchase/in_app_purchase_android/CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.