Skip to content
Open
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,7 @@ linter:
- type_annotate_public_apis
- type_init_formals
- type_literal_in_constant_pattern
- unintended_html_in_doc_comment # DIFFERENT FROM FLUTTER/FLUTTER: Disable due to an issue that has been fixed, so just hasn't been adopted there yet.
- unawaited_futures # DIFFERENT FROM FLUTTER/FLUTTER: It's disabled there for "too many false positives"; that's not an issue here, and missing awaits have caused production issues in plugins.
- unnecessary_await_in_return
- unnecessary_brace_in_string_interps
Expand Down
6 changes: 5 additions & 1 deletion packages/camera/camera_android_camerax/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.7.1+1

* Fixes dartdoc comments that accidentally used HTML.

## 0.7.1

* Removes outdated restrictions against concurrent camera use cases.
Expand Down Expand Up @@ -518,4 +522,4 @@ this plugin should now be compatible with [google_ml_kit_flutter](https://github
* Displaying a live camera preview
* Image streaming

See [`README.md`](README.md) for more details on the limitations of this implementation.
See [`README.md`](README.md) for more details on the limitations of this implementation.
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ enum CameraStateType {
unknown,
}

/// The types (T) properly wrapped to be used as a LiveData<T>.
/// The types (T) properly wrapped to be used as a `LiveData<T>`.
enum LiveDataSupportedType { cameraState, zoomState }

/// Immutable class for describing the range of two integer values.
Expand Down
2 changes: 1 addition & 1 deletion packages/camera/camera_android_camerax/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: camera_android_camerax
description: Android implementation of the camera plugin using the CameraX library.
repository: https://github.com/flutter/packages/tree/main/packages/camera/camera_android_camerax
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+camera%22
version: 0.7.1
version: 0.7.1+1

environment:
sdk: ^3.9.0
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,12 @@ import 'dart:async';
import 'dart:js_interop';
import 'dart:ui';

// ignore_for_file: implementation_imports
import 'package:camera_web/src/camera.dart';
import 'package:camera_web/src/camera_service.dart';
import 'package:camera_web/src/shims/dart_js_util.dart';
import 'package:camera_web/src/types/types.dart';
import 'package:mockito/annotations.dart';
import 'package:mockito/mockito.dart';
// TODO(srujzs): This is exported in `package:web` 0.6.0. Remove this when it is available.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was just opportunistic cleanup to a test file I was already editing, since I happened to notice it. We already require package:web 1.0+ for example.

import 'package:web/src/helpers/events/streams.dart';
import 'package:web/web.dart' as web;

@GenerateNiceMocks(<MockSpec<dynamic>>[
Expand Down Expand Up @@ -80,12 +77,12 @@ class MockScreen {

@JSExport()
class MockScreenOrientation {
/// JSPromise<JSAny?> Function(web.OrientationLockType orientation)
/// `JSPromise<JSAny?> Function(web.OrientationLockType orientation)`
JSFunction lock = (web.OrientationLockType orientation) {
return Future<void>.value().toJS;
}.toJS;

/// void Function()
/// `void Function()`
late JSFunction unlock;
late web.OrientationType type;
}
Expand All @@ -97,7 +94,7 @@ class MockDocument {

@JSExport()
class MockElement {
/// JSPromise<JSAny?> Function([FullscreenOptions options])
/// `JSPromise<JSAny?> Function([FullscreenOptions options])`
JSFunction requestFullscreen = ([web.FullscreenOptions? options]) {
return Future<void>.value().toJS;
}.toJS;
Expand All @@ -110,30 +107,30 @@ class MockNavigator {

@JSExport()
class MockMediaDevices {
/// JSPromise<web.MediaStream> Function([web.MediaStreamConstraints? constraints])
/// `JSPromise<web.MediaStream> Function([web.MediaStreamConstraints? constraints])`
late JSFunction getUserMedia;

/// web.MediaTrackSupportedConstraints Function()
/// `web.MediaTrackSupportedConstraints Function()`
late JSFunction getSupportedConstraints;

/// JSPromise<JSArray<web.MediaDeviceInfo>> Function()
/// `JSPromise<JSArray<web.MediaDeviceInfo>> Function()`
late JSFunction enumerateDevices;
}

@JSExport()
class MockMediaStreamTrack {
/// web.MediaTrackCapabilities Function();
/// `web.MediaTrackCapabilities Function()`
late JSFunction getCapabilities;

/// web.MediaTrackSettings Function()
/// `web.MediaTrackSettings Function()`
JSFunction getSettings = () {
return web.MediaTrackSettings();
}.toJS;

/// JSPromise<JSAny?> Function([web.MediaTrackConstraints? constraints])
/// `JSPromise<JSAny?> Function([web.MediaTrackConstraints? constraints])`
late JSFunction applyConstraints;

/// void Function()
/// `void Function()`
JSFunction stop = () {}.toJS;
}

Expand All @@ -145,24 +142,24 @@ class MockVideoElement {

@JSExport()
class MockMediaRecorder {
/// void Function(String type, web.EventListener? callback, [JSAny options])
/// `void Function(String type, web.EventListener? callback, [JSAny options])`
JSFunction addEventListener =
(String type, web.EventListener? callback, [JSAny? options]) {}.toJS;

/// void Function(String type, web.EventListener? callback, [JSAny options])
/// `void Function(String type, web.EventListener? callback, [JSAny options])`
JSFunction removeEventListener =
(String type, web.EventListener? callback, [JSAny? options]) {}.toJS;

/// void Function([int timeslice])
/// `void Function([int timeslice])`
JSFunction start = ([int? timeslice]) {}.toJS;

/// void Function()
/// `void Function()`
JSFunction pause = () {}.toJS;

/// void Function()
/// `void Function()`
JSFunction resume = () {}.toJS;

/// void Function()
/// `void Function()`
JSFunction stop = () {}.toJS;

web.RecordingState state = 'inactive';
Expand Down Expand Up @@ -197,9 +194,9 @@ class FakeMediaError {
final String message;
}

/// A fake [ElementStream] that listens to the provided [_stream] on [listen].
/// A fake [web.ElementStream] that listens to the provided [_stream] on [listen].
class FakeElementStream<T extends web.Event> extends Fake
implements ElementStream<T> {
implements web.ElementStream<T> {
FakeElementStream(this._stream);

final Stream<T> _stream;
Expand All @@ -220,15 +217,15 @@ class FakeElementStream<T extends web.Event> extends Fake
}
}

/// A fake [BlobEvent] that returns the provided blob [data].
/// A fake [web.BlobEvent] that returns the provided blob [data].
@JSExport()
class FakeBlobEvent {
FakeBlobEvent(this.data);

final web.Blob? data;
}

/// A fake [DomException] that returns the provided error [_name] and [_message].
/// A fake [web.DomException] that returns the provided error [_name] and [_message].
@JSExport()
class FakeErrorEvent {
FakeErrorEvent(this.type, [this.message = '']);
Expand Down Expand Up @@ -272,7 +269,7 @@ class MockEventStreamProvider<T extends web.Event> extends Mock
}

@override
ElementStream<T> forElement(web.Element? e, {bool? useCapture = false}) {
web.ElementStream<T> forElement(web.Element? e, {bool? useCapture = false}) {
return super.noSuchMethod(
Invocation.method(
#forElement,
Expand All @@ -281,7 +278,7 @@ class MockEventStreamProvider<T extends web.Event> extends Mock
),
returnValue: FakeElementStream<T>(Stream<T>.empty()),
)
as ElementStream<T>;
as web.ElementStream<T>;
}
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.4.0+9

* Fixes dartdoc comments that accidentally used HTML.

## 0.4.0+8

* Bumps com.android.tools.build:gradle from 8.12.1 to 8.13.1.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -447,12 +447,12 @@ abstract class InAppPurchaseApi {

@FlutterApi()
abstract class InAppPurchaseCallbackApi {
/// Called for BillingClientStateListener#onBillingServiceDisconnected().
/// Called for `BillingClientStateListener#onBillingServiceDisconnected()`.
void onBillingServiceDisconnected(int callbackHandle);

/// Called for PurchasesUpdatedListener#onPurchasesUpdated(BillingResult, List<Purchase>).
/// Called for `PurchasesUpdatedListener#onPurchasesUpdated(BillingResult, List<Purchase>)`.
void onPurchasesUpdated(PlatformPurchasesResponse update);

/// Called for UserChoiceBillingListener#userSelectedAlternativeBilling(UserChoiceDetails).
/// Called for `UserChoiceBillingListener#userSelectedAlternativeBilling(UserChoiceDetails)`.
void userSelectedalternativeBilling(PlatformUserChoiceDetails details);
}
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: An implementation for the Android platform of the Flutter `in_app_p
repository: https://github.com/flutter/packages/tree/main/packages/in_app_purchase/in_app_purchase_android
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+in_app_purchase%22

version: 0.4.0+8
version: 0.4.0+9

environment:
sdk: ^3.9.0
Expand Down
3 changes: 2 additions & 1 deletion packages/metrics_center/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## NEXT
## 1.0.15

* Fixes dartdoc comments that accidentally used HTML.
* Updates minimum supported SDK version to Flutter 3.35/Dart 3.9.

## 1.0.14
Expand Down
2 changes: 1 addition & 1 deletion packages/metrics_center/lib/src/skiaperf.dart
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ class SkiaPerfPoint extends MetricPoint {
);
}

/// In the format of '<owner>/<name>' such as 'flutter/flutter' or
/// In the format of `<owner>/<name>` such as 'flutter/flutter' or
/// 'flutter/engine'.
final String githubRepo;

Expand Down
2 changes: 1 addition & 1 deletion packages/metrics_center/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: metrics_center
version: 1.0.14
version: 1.0.15
description:
Support multiple performance metrics sources/formats and destinations.
repository: https://github.com/flutter/packages/tree/main/packages/metrics_center
Expand Down
4 changes: 4 additions & 0 deletions packages/pigeon/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 26.2.4

* Fixes dartdoc comments that accidentally used HTML.

## 26.2.3

* Produces a helpful error message when a method return type is missing or an
Expand Down
4 changes: 2 additions & 2 deletions packages/pigeon/lib/src/ast.dart
Original file line number Diff line number Diff line change
Expand Up @@ -496,13 +496,13 @@ class TypeDeclaration {
associatedProxyApi = null,
typeArguments = const <TypeDeclaration>[];

/// The base name of the [TypeDeclaration] (ex 'Foo' to 'Foo<Bar>?').
/// The base name of the [TypeDeclaration] (ex `Foo` to `Foo<Bar>?`).
final String baseName;

/// Whether the declaration represents 'void'.
bool get isVoid => baseName == 'void';

/// Whether the type arguments to the entity (ex 'Bar' to 'Foo<Bar>?').
/// Whether the type arguments to the entity (ex `Bar` to `Foo<Bar>?`).
final List<TypeDeclaration> typeArguments;

/// Whether the type is nullable.
Expand Down
4 changes: 4 additions & 0 deletions packages/pigeon/lib/src/dart/dart_generator.dart
Original file line number Diff line number Diff line change
Expand Up @@ -523,13 +523,15 @@ class DartGenerator extends StructuredGenerator<InternalDartOptions> {

/// Writes the code for host [Api], [api].
/// Example:
/// ```dart
/// class FooCodec extends StandardMessageCodec {...}
///
/// abstract class Foo {
/// static const MessageCodec<Object?> codec = FooCodec();
/// int add(int x, int y);
/// static void setUp(Foo api, {BinaryMessenger? binaryMessenger}) {...}
/// }
/// ```
@override
void writeFlutterApi(
InternalDartOptions generatorOptions,
Expand Down Expand Up @@ -599,13 +601,15 @@ class DartGenerator extends StructuredGenerator<InternalDartOptions> {

/// Writes the code for host [Api], [api].
/// Example:
/// ```dart
/// class FooCodec extends StandardMessageCodec {...}
///
/// class Foo {
/// Foo(BinaryMessenger? binaryMessenger) {}
/// static const MessageCodec<Object?> codec = FooCodec();
/// Future<int> add(int x, int y) async {...}
/// }
/// ```
///
/// Messages will be sent and received in a list.
///
Expand Down
2 changes: 2 additions & 0 deletions packages/pigeon/lib/src/java/java_generator.dart
Original file line number Diff line number Diff line change
Expand Up @@ -728,13 +728,15 @@ if (wrapped == null) {

/// Writes the code for a flutter [Api], [api].
/// Example:
/// ```java
/// public static final class Foo {
/// public Foo(BinaryMessenger argBinaryMessenger) {...}
/// public interface Result<T> {
/// void reply(T reply);
/// }
/// public int add(int x, int y, Result<int> result) {...}
/// }
/// ```
@override
void writeFlutterApi(
InternalJavaOptions generatorOptions,
Expand Down
2 changes: 1 addition & 1 deletion packages/pigeon/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: pigeon
description: Code generator tool to make communication between Flutter and the host platform type-safe and easier.
repository: https://github.com/flutter/packages/tree/main/packages/pigeon
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+pigeon%22
version: 26.2.3 # This must match the version in lib/src/generator_tools.dart
version: 26.2.4 # This must match the version in lib/src/generator_tools.dart

environment:
sdk: ^3.9.0
Expand Down
4 changes: 4 additions & 0 deletions packages/rfw/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 1.1.3

* Fixes dartdoc comments that accidentally used HTML.

## 1.1.2

* Removes outdated call for feedback from the README.
Expand Down
5 changes: 3 additions & 2 deletions packages/rfw/lib/src/flutter/argument_decoders.dart
Original file line number Diff line number Diff line change
Expand Up @@ -614,8 +614,9 @@ class ArgumentDecoders {
/// The first argument must be the `values` list for that enum; this is the
/// list of values that is searched.
///
/// For example, `enumValue<TileMode>(TileMode.values, source, ['tileMode']) ??
/// TileMode.clamp` reads the `tileMode` key of `source`, and looks for the
/// For example,
/// `enumValue<TileMode>(TileMode.values, source, ['tileMode']) ?? TileMode.clamp`
/// reads the `tileMode` key of `source`, and looks for the
/// first match in [TileMode.values], defaulting to [TileMode.clamp] if
/// nothing matches; thus, the string `mirror` would return [TileMode.mirror].
static T? enumValue<T>(List<T> values, DataSource source, List<Object> key) {
Expand Down
2 changes: 1 addition & 1 deletion packages/rfw/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: rfw
description: "Remote Flutter widgets: a library for rendering declarative widget description files at runtime."
repository: https://github.com/flutter/packages/tree/main/packages/rfw
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+rfw%22
version: 1.1.2
version: 1.1.3

environment:
sdk: ^3.9.0
Expand Down
4 changes: 4 additions & 0 deletions packages/shared_preferences/shared_preferences/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 2.5.5

* Fixes dartdoc comments that accidentally used HTML.

## 2.5.4

* Updates dependencies for the `shared_preferences_tool` DevTools extension and fixes related deprecations.
Expand Down
Loading
Loading