[various] Add unintended_html_in_doc_comment to analysis options

analysis_options.yaml

@@ -196,6 +196,7 @@ linter:
     - type_annotate_public_apis
     - type_init_formals
     - type_literal_in_constant_pattern
+    - unintended_html_in_doc_comment # DIFFERENT FROM FLUTTER/FLUTTER: Disabled due to an issue that has been fixed, so just hasn't been adopted there yet.
     - unawaited_futures # DIFFERENT FROM FLUTTER/FLUTTER: It's disabled there for "too many false positives"; that's not an issue here, and missing awaits have caused production issues in plugins.
     - unnecessary_await_in_return
     - unnecessary_brace_in_string_interps

packages/camera/camera_android_camerax/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.7.1+1
+
+* Fixes dartdoc comments that accidentally used HTML.
+
 ## 0.7.1
 
 * Removes outdated restrictions against concurrent camera use cases.
@@ -518,4 +522,4 @@ this plugin should now be compatible with [google_ml_kit_flutter](https://github
     * Displaying a live camera preview
     * Image streaming
 
-  See [`README.md`](README.md) for more details on the limitations of this implementation.
+  See [`README.md`](README.md) for more details on the limitations of this implementation.

packages/camera/camera_android_camerax/pigeons/camerax_library.dart

@@ -112,7 +112,7 @@ enum CameraStateType {
   unknown,
 }
 
-/// The types (T) properly wrapped to be used as a LiveData<T>.
+/// The types (T) properly wrapped to be used as a `LiveData<T>`.
 enum LiveDataSupportedType { cameraState, zoomState }
 
 /// Immutable class for describing the range of two integer values.

packages/camera/camera_android_camerax/pubspec.yaml

@@ -2,7 +2,7 @@ name: camera_android_camerax
 description: Android implementation of the camera plugin using the CameraX library.
 repository: https://github.com/flutter/packages/tree/main/packages/camera/camera_android_camerax
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+camera%22
-version: 0.7.1
+version: 0.7.1+1
 
 environment:
   sdk: ^3.9.0

packages/camera/camera_web/example/integration_test/helpers/mocks.dart

@@ -8,15 +8,12 @@ import 'dart:async';
 import 'dart:js_interop';
 import 'dart:ui';
 
-// ignore_for_file: implementation_imports
 import 'package:camera_web/src/camera.dart';
 import 'package:camera_web/src/camera_service.dart';
 import 'package:camera_web/src/shims/dart_js_util.dart';
 import 'package:camera_web/src/types/types.dart';
 import 'package:mockito/annotations.dart';
 import 'package:mockito/mockito.dart';
-// TODO(srujzs): This is exported in `package:web` 0.6.0. Remove this when it is available.
-import 'package:web/src/helpers/events/streams.dart';
 import 'package:web/web.dart' as web;
 
 @GenerateNiceMocks(<MockSpec<dynamic>>[
@@ -80,12 +77,12 @@ class MockScreen {
 
 @JSExport()
 class MockScreenOrientation {
-  /// JSPromise<JSAny?> Function(web.OrientationLockType orientation)
+  /// `JSPromise<JSAny?> Function(web.OrientationLockType orientation)`
   JSFunction lock = (web.OrientationLockType orientation) {
     return Future<void>.value().toJS;
   }.toJS;
 
-  /// void Function()
+  /// `void Function()`
   late JSFunction unlock;
   late web.OrientationType type;
 }
@@ -97,7 +94,7 @@ class MockDocument {
 
 @JSExport()
 class MockElement {
-  /// JSPromise<JSAny?> Function([FullscreenOptions options])
+  /// `JSPromise<JSAny?> Function([FullscreenOptions options])`
   JSFunction requestFullscreen = ([web.FullscreenOptions? options]) {
     return Future<void>.value().toJS;
   }.toJS;
@@ -110,30 +107,30 @@ class MockNavigator {
 
 @JSExport()
 class MockMediaDevices {
-  /// JSPromise<web.MediaStream> Function([web.MediaStreamConstraints? constraints])
+  /// `JSPromise<web.MediaStream> Function([web.MediaStreamConstraints? constraints])`
   late JSFunction getUserMedia;
 
-  /// web.MediaTrackSupportedConstraints Function()
+  /// `web.MediaTrackSupportedConstraints Function()`
   late JSFunction getSupportedConstraints;
 
-  /// JSPromise<JSArray<web.MediaDeviceInfo>> Function()
+  /// `JSPromise<JSArray<web.MediaDeviceInfo>> Function()`
   late JSFunction enumerateDevices;
 }
 
 @JSExport()
 class MockMediaStreamTrack {
-  /// web.MediaTrackCapabilities Function();
+  /// `web.MediaTrackCapabilities Function()`
   late JSFunction getCapabilities;
 
-  /// web.MediaTrackSettings Function()
+  /// `web.MediaTrackSettings Function()`
   JSFunction getSettings = () {
     return web.MediaTrackSettings();
   }.toJS;
 
-  /// JSPromise<JSAny?> Function([web.MediaTrackConstraints? constraints])
+  /// `JSPromise<JSAny?> Function([web.MediaTrackConstraints? constraints])`
   late JSFunction applyConstraints;
 
-  /// void Function()
+  /// `void Function()`
   JSFunction stop = () {}.toJS;
 }
 
@@ -145,24 +142,24 @@ class MockVideoElement {
 
 @JSExport()
 class MockMediaRecorder {
-  /// void Function(String type, web.EventListener? callback, [JSAny options])
+  /// `void Function(String type, web.EventListener? callback, [JSAny options])`
   JSFunction addEventListener =
       (String type, web.EventListener? callback, [JSAny? options]) {}.toJS;
 
-  /// void Function(String type, web.EventListener? callback, [JSAny options])
+  /// `void Function(String type, web.EventListener? callback, [JSAny options])`
   JSFunction removeEventListener =
       (String type, web.EventListener? callback, [JSAny? options]) {}.toJS;
 
-  /// void Function([int timeslice])
+  /// `void Function([int timeslice])`
   JSFunction start = ([int? timeslice]) {}.toJS;
 
-  /// void Function()
+  /// `void Function()`
   JSFunction pause = () {}.toJS;
 
-  /// void Function()
+  /// `void Function()`
   JSFunction resume = () {}.toJS;
 
-  /// void Function()
+  /// `void Function()`
   JSFunction stop = () {}.toJS;
 
   web.RecordingState state = 'inactive';
@@ -197,9 +194,9 @@ class FakeMediaError {
   final String message;
 }
 
-/// A fake [ElementStream] that listens to the provided [_stream] on [listen].
+/// A fake [web.ElementStream] that listens to the provided [_stream] on [listen].
 class FakeElementStream<T extends web.Event> extends Fake
-    implements ElementStream<T> {
+    implements web.ElementStream<T> {
   FakeElementStream(this._stream);
 
   final Stream<T> _stream;
@@ -220,15 +217,15 @@ class FakeElementStream<T extends web.Event> extends Fake
   }
 }
 
-/// A fake [BlobEvent] that returns the provided blob [data].
+/// A fake [web.BlobEvent] that returns the provided blob [data].
 @JSExport()
 class FakeBlobEvent {
   FakeBlobEvent(this.data);
 
   final web.Blob? data;
 }
 
-/// A fake [DomException] that returns the provided error [_name] and [_message].
+/// A fake [web.DomException] that returns the provided error [_name] and [_message].
 @JSExport()
 class FakeErrorEvent {
   FakeErrorEvent(this.type, [this.message = '']);
@@ -272,7 +269,7 @@ class MockEventStreamProvider<T extends web.Event> extends Mock
   }
 
   @override
-  ElementStream<T> forElement(web.Element? e, {bool? useCapture = false}) {
+  web.ElementStream<T> forElement(web.Element? e, {bool? useCapture = false}) {
     return super.noSuchMethod(
           Invocation.method(
             #forElement,
@@ -281,7 +278,7 @@ class MockEventStreamProvider<T extends web.Event> extends Mock
           ),
           returnValue: FakeElementStream<T>(Stream<T>.empty()),
         )
-        as ElementStream<T>;
+        as web.ElementStream<T>;
   }
 }
 

packages/in_app_purchase/in_app_purchase_android/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.4.0+9
+
+* Fixes dartdoc comments that accidentally used HTML.
+
 ## 0.4.0+8
 
 * Bumps com.android.tools.build:gradle from 8.12.1 to 8.13.1.

packages/in_app_purchase/in_app_purchase_android/pigeons/messages.dart

@@ -447,12 +447,12 @@ abstract class InAppPurchaseApi {
 
 @FlutterApi()
 abstract class InAppPurchaseCallbackApi {
-  /// Called for BillingClientStateListener#onBillingServiceDisconnected().
+  /// Called for `BillingClientStateListener#onBillingServiceDisconnected()`.
   void onBillingServiceDisconnected(int callbackHandle);
 
-  /// Called for PurchasesUpdatedListener#onPurchasesUpdated(BillingResult, List<Purchase>).
+  /// Called for `PurchasesUpdatedListener#onPurchasesUpdated(BillingResult, List<Purchase>)`.
   void onPurchasesUpdated(PlatformPurchasesResponse update);
 
-  /// Called for UserChoiceBillingListener#userSelectedAlternativeBilling(UserChoiceDetails).
+  /// Called for `UserChoiceBillingListener#userSelectedAlternativeBilling(UserChoiceDetails)`.
   void userSelectedalternativeBilling(PlatformUserChoiceDetails details);
 }

packages/in_app_purchase/in_app_purchase_android/pubspec.yaml

@@ -3,7 +3,7 @@ description: An implementation for the Android platform of the Flutter `in_app_p
 repository: https://github.com/flutter/packages/tree/main/packages/in_app_purchase/in_app_purchase_android
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+in_app_purchase%22
 
-version: 0.4.0+8
+version: 0.4.0+9
 
 environment:
   sdk: ^3.9.0

packages/metrics_center/CHANGELOG.md

@@ -1,5 +1,6 @@
-## NEXT
+## 1.0.15
 
+* Fixes dartdoc comments that accidentally used HTML.
 * Updates minimum supported SDK version to Flutter 3.35/Dart 3.9.
 
 ## 1.0.14

packages/metrics_center/lib/src/skiaperf.dart

@@ -126,7 +126,7 @@ class SkiaPerfPoint extends MetricPoint {
     );
   }
 
-  /// In the format of '<owner>/<name>' such as 'flutter/flutter' or
+  /// In the format of `<owner>/<name>` such as 'flutter/flutter' or
   /// 'flutter/engine'.
   final String githubRepo;
 

packages/metrics_center/pubspec.yaml

@@ -1,5 +1,5 @@
 name: metrics_center
-version: 1.0.14
+version: 1.0.15
 description:
   Support multiple performance metrics sources/formats and destinations.
 repository: https://github.com/flutter/packages/tree/main/packages/metrics_center

packages/pigeon/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 26.2.4
+
+* Fixes dartdoc comments that accidentally used HTML.
+
 ## 26.2.3
 
 * Produces a helpful error message when a method return type is missing or an

packages/pigeon/lib/src/ast.dart

@@ -496,13 +496,13 @@ class TypeDeclaration {
       associatedProxyApi = null,
       typeArguments = const <TypeDeclaration>[];
 
-  /// The base name of the [TypeDeclaration] (ex 'Foo' to 'Foo<Bar>?').
+  /// The base name of the [TypeDeclaration] (ex `Foo` to `Foo<Bar>?`).
   final String baseName;
 
   /// Whether the declaration represents 'void'.
   bool get isVoid => baseName == 'void';
 
-  /// Whether the type arguments to the entity (ex 'Bar' to 'Foo<Bar>?').
+  /// Whether the type arguments to the entity (ex `Bar` to `Foo<Bar>?`).
   final List<TypeDeclaration> typeArguments;
 
   /// Whether the type is nullable.

packages/pigeon/lib/src/dart/dart_generator.dart

@@ -523,13 +523,15 @@ class DartGenerator extends StructuredGenerator<InternalDartOptions> {
 
   /// Writes the code for host [Api], [api].
   /// Example:
+  /// ```dart
   /// class FooCodec extends StandardMessageCodec {...}
   ///
   /// abstract class Foo {
   ///   static const MessageCodec<Object?> codec = FooCodec();
   ///   int add(int x, int y);
   ///   static void setUp(Foo api, {BinaryMessenger? binaryMessenger}) {...}
   /// }
+  /// ```
   @override
   void writeFlutterApi(
     InternalDartOptions generatorOptions,
@@ -599,13 +601,15 @@ class DartGenerator extends StructuredGenerator<InternalDartOptions> {
 
   /// Writes the code for host [Api], [api].
   /// Example:
+  /// ```dart
   /// class FooCodec extends StandardMessageCodec {...}
   ///
   /// class Foo {
   ///   Foo(BinaryMessenger? binaryMessenger) {}
   ///   static const MessageCodec<Object?> codec = FooCodec();
   ///   Future<int> add(int x, int y) async {...}
   /// }
+  /// ```
   ///
   /// Messages will be sent and received in a list.
   ///

packages/pigeon/lib/src/generator_tools.dart

@@ -15,7 +15,7 @@ import 'generator.dart';
 /// The current version of pigeon.
 ///
 /// This must match the version in pubspec.yaml.
-const String pigeonVersion = '26.2.3';
+const String pigeonVersion = '26.2.4';
 
 /// Default plugin package name.
 const String defaultPluginPackageName = 'dev.flutter.pigeon';

packages/pigeon/lib/src/java/java_generator.dart

@@ -728,13 +728,15 @@ if (wrapped == null) {
 
   /// Writes the code for a flutter [Api], [api].
   /// Example:
+  /// ```java
   /// public static final class Foo {
   ///   public Foo(BinaryMessenger argBinaryMessenger) {...}
   ///   public interface Result<T> {
   ///     void reply(T reply);
   ///   }
   ///   public int add(int x, int y, Result<int> result) {...}
   /// }
+  /// ```
   @override
   void writeFlutterApi(
     InternalJavaOptions generatorOptions,

packages/pigeon/pubspec.yaml

@@ -2,7 +2,7 @@ name: pigeon
 description: Code generator tool to make communication between Flutter and the host platform type-safe and easier.
 repository: https://github.com/flutter/packages/tree/main/packages/pigeon
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+pigeon%22
-version: 26.2.3 # This must match the version in lib/src/generator_tools.dart
+version: 26.2.4 # This must match the version in lib/src/generator_tools.dart
 
 environment:
   sdk: ^3.9.0

packages/rfw/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 1.1.3
+
+* Fixes dartdoc comments that accidentally used HTML.
+
 ## 1.1.2
 
 * Removes outdated call for feedback from the README.

packages/rfw/lib/src/flutter/argument_decoders.dart

@@ -614,8 +614,9 @@ class ArgumentDecoders {
   /// The first argument must be the `values` list for that enum; this is the
   /// list of values that is searched.
   ///
-  /// For example, `enumValue<TileMode>(TileMode.values, source, ['tileMode']) ??
-  /// TileMode.clamp` reads the `tileMode` key of `source`, and looks for the
+  /// For example,
+  /// `enumValue<TileMode>(TileMode.values, source, ['tileMode']) ?? TileMode.clamp`
+  /// reads the `tileMode` key of `source`, and looks for the
   /// first match in [TileMode.values], defaulting to [TileMode.clamp] if
   /// nothing matches; thus, the string `mirror` would return [TileMode.mirror].
   static T? enumValue<T>(List<T> values, DataSource source, List<Object> key) {

packages/rfw/pubspec.yaml

@@ -2,7 +2,7 @@ name: rfw
 description: "Remote Flutter widgets: a library for rendering declarative widget description files at runtime."
 repository: https://github.com/flutter/packages/tree/main/packages/rfw
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+rfw%22
-version: 1.1.2
+version: 1.1.3
 
 environment:
   sdk: ^3.9.0

packages/shared_preferences/shared_preferences/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 2.5.5
+
+* Fixes dartdoc comments that accidentally used HTML.
+
 ## 2.5.4
 
 * Updates dependencies for the `shared_preferences_tool` DevTools extension and fixes related deprecations.