[various] Add unintended_html_in_doc_comment to analysis options#11303
Merged
auto-submit[bot] merged 7 commits intoflutter:mainfrom Mar 25, 2026
Merged
[various] Add unintended_html_in_doc_comment to analysis options#11303auto-submit[bot] merged 7 commits intoflutter:mainfrom
unintended_html_in_doc_comment to analysis options#11303auto-submit[bot] merged 7 commits intoflutter:mainfrom
Conversation
stuartmorgan-g
requested review from
Hixie,
LongCatIsLooong,
bkonyi,
bparrishMines,
camsim99,
gmackall,
hellohuanlin,
jesswrd,
mdebbar and
tarrinneal
as code owners
github-actions
bot
added
p: metrics_center
p: pigeon
p: rfw
stuartmorgan-g
commented
Mar 19, 2026
| import 'package:camera_web/src/types/types.dart'; | ||
| import 'package:mockito/annotations.dart'; | ||
| import 'package:mockito/mockito.dart'; | ||
| // TODO(srujzs): This is exported in `package:web` 0.6.0. Remove this when it is available. |
Collaborator
Author
There was a problem hiding this comment.
This was just opportunistic cleanup to a test file I was already editing, since I happened to notice it. We already require package:web 1.0+ for example.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the unintended_html_in_doc_comment lint rule to the analysis options and addresses violations across several packages. The changes primarily involve replacing HTML-like tags in Dart doc comments with markdown code blocks (e.g., changing <T> to <T> or adding ```dart blocks for code examples). This is a valuable improvement for documentation clarity and consistency, aligning with best practices for Dartdoc. Version numbers in pubspec.yaml and `CHANGELOG.md` files have been updated accordingly for the affected packages.
tarrinneal
approved these changes
Mar 19, 2026
mdebbar
approved these changes
Mar 24, 2026
stuartmorgan-g
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/packages/11303, because Pull request flutter/packages/11303 is not in a mergeable state. |
stuartmorgan-g
added
CICD
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 25, 2026
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 25, 2026
flutter/packages@8dcfd11...5909bdd 2026-03-25 47866232+chunhtai@users.noreply.github.com [ci] add more permissions for create-pull-request (flutter/packages#11302) 2026-03-25 stuartmorgan@google.com [various] Add `unintended_html_in_doc_comment` to analysis options (flutter/packages#11303) 2026-03-25 matt.boetger@gmail.com Use deprecated dependency until legacy renderer is removed (flutter/packages#11185) 2026-03-25 louisehsu@google.com [in_app_purchase_storekit] Address flaky tests (flutter/packages#11270) 2026-03-25 stuartmorgan@google.com [google_maps_flutter] Fix A2A iOS builds (flutter/packages#11290) 2026-03-25 stuartmorgan@google.com [mustache_template] Fix broken README link (flutter/packages#11306) 2026-03-25 stuartmorgan@google.com [ci] Add a workflow to auto-remove CICD label (flutter/packages#11301) 2026-03-25 stuartmorgan@google.com [various] Convert plugin builds to Kotlin gradle (flutter/packages#11172) 2026-03-25 spkhalad@gmail.com [webview_flutter_platform_interface] Add support for getting cookie (flutter/packages#11037) 2026-03-25 stuartmorgan@google.com [cupertino_icons] Remove empty Dart file (flutter/packages#11308) 2026-03-25 stuartmorgan@google.com [camera] Regenerate iOS example with Swift (flutter/packages#11283) 2026-03-25 tarrinneal@gmail.com [pigeon] Optimize data class equality and hashing in Dart, Kotlin, java, and Swift, adds equality in other languages (flutter/packages#11140) 2026-03-25 katelovett@google.com [two_dimensional_scrollables] Fix span border decorations in flipped cross axes (flutter/packages#11334) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
okorohelijah
pushed a commit
to okorohelijah/packages
that referenced
this pull request
Mar 26, 2026
…lutter#11303) Adds `unintended_html_in_doc_comment` to our analysis options, and fixes violations. This does a version bump even for cases where the comments being fixed are internal, because part of the goal here is to eliminate `pana` deductions on pub.dev, and that doesn't take into account whether the violation is client-facing or just package-developer-facing. Fixes flutter/flutter#183860 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Mar 26, 2026
…er#184123) flutter/packages@8dcfd11...5909bdd 2026-03-25 47866232+chunhtai@users.noreply.github.com [ci] add more permissions for create-pull-request (flutter/packages#11302) 2026-03-25 stuartmorgan@google.com [various] Add `unintended_html_in_doc_comment` to analysis options (flutter/packages#11303) 2026-03-25 matt.boetger@gmail.com Use deprecated dependency until legacy renderer is removed (flutter/packages#11185) 2026-03-25 louisehsu@google.com [in_app_purchase_storekit] Address flaky tests (flutter/packages#11270) 2026-03-25 stuartmorgan@google.com [google_maps_flutter] Fix A2A iOS builds (flutter/packages#11290) 2026-03-25 stuartmorgan@google.com [mustache_template] Fix broken README link (flutter/packages#11306) 2026-03-25 stuartmorgan@google.com [ci] Add a workflow to auto-remove CICD label (flutter/packages#11301) 2026-03-25 stuartmorgan@google.com [various] Convert plugin builds to Kotlin gradle (flutter/packages#11172) 2026-03-25 spkhalad@gmail.com [webview_flutter_platform_interface] Add support for getting cookie (flutter/packages#11037) 2026-03-25 stuartmorgan@google.com [cupertino_icons] Remove empty Dart file (flutter/packages#11308) 2026-03-25 stuartmorgan@google.com [camera] Regenerate iOS example with Swift (flutter/packages#11283) 2026-03-25 tarrinneal@gmail.com [pigeon] Optimize data class equality and hashing in Dart, Kotlin, java, and Swift, adds equality in other languages (flutter/packages#11140) 2026-03-25 katelovett@google.com [two_dimensional_scrollables] Fix span border decorations in flipped cross axes (flutter/packages#11334) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
unintended_html_in_doc_commentto our analysis options, and fixes violations.This does a version bump even for cases where the comments being fixed are internal, because part of the goal here is to eliminate
panadeductions on pub.dev, and that doesn't take into account whether the violation is client-facing or just package-developer-facing.Fixes flutter/flutter#183860
Pre-Review Checklist
[shared_preferences]///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2