interop: specify deposits-complete handling#370
Merged
Conversation
protolambda
requested review from
ajsutton,
mslipper and
sebastianst
as code owners
tynes
approved these changes
Sep 11, 2024
Contributor
tynes
left a comment
tynes
left a comment
There was a problem hiding this comment.
Confirmed that this matches the the implementation in ethereum-optimism/optimism#11712
tynes
approved these changes
Sep 17, 2024
tynes
approved these changes
Sep 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Specify the deposits-complete system transaction functionality, the exact transaction contents, and the source-hash computation.
Also expand the tx-pool section with the effective-gas-limit change, to accommodate the system transaction.
Question: previously it was effectively a 70k gas reservation, so expanding it to 100k means the gas limit effectively shrinks by 30k. Setting the total gas limit from 30M to 30,030k seems a little silly though. But some product feedback may be useful here, if anyone strongly relies on having that 30k gas available.