Merged
Conversation
tynes
reviewed
Sep 3, 2024
tynes
reviewed
Sep 3, 2024
tynes
reviewed
Sep 3, 2024
617ec63 to
67e362b
Compare
67d2030 to
bd0ed78
Compare
Contributor
|
Rebased on develop, applied a bunch of fixes/improvements to the tests, fixed the deposit-source of the comple-deposits tx not mixing in the sequence-number properly, and updated metadata etc. Now just need the spec to properly document the new deposit-source, and then ready to merge. |
Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com>
Contributor
|
Looks like the contracts failures come from warnings from solc Perhaps we should use the |
Contributor
|
Rebasing this PR on develop, and updating the interfaces metadata |
bd0ed78 to
447e7b3
Compare
Contributor
|
Rebased. But |
tynes
approved these changes
Sep 11, 2024
protolambda
approved these changes
Sep 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To get ready for Interop, we need to make sure to disable
ExecutingMessagesto be referenced by Deposit transactions.This PR touches both the client and the relevant pre-deploy contracts.
more context: ticket & spec
Tests
Both solidity and go additions and modifications have been properly tested.
Additional context
you can check #11362 for more context on the conversations leading to this final PR
Metadata