Create dedicated lint CI job#1181
Conversation
|
I think I need a manual approval for the new workflow. |
|
I'll squash commits after we have a successful run. I want to keep the commit history in case I need to revert. |
|
@ahrtr, could you please click the button to run the workflows I added? I can also test on my fork otherwise. Thanks. |
* Remove the linting step from all the workflows, it should help with speed when running those CI jobs. * Introduce a new lint job and a template to simplify reusing it for Windows and Linux. Signed-off-by: Ivan Valdes <ivan@vald.es>
ivanvc
force-pushed
the
split-lint-ci-job
branch
from
3b91676 to
68aeba9
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, fuweid, ivanvc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sorry, did not get your question. Where to click the button? Seems that you need to add |
If you see the checks for this pull request, the new Lint jobs are not running. This is because GitHub doesn't run new workflows in PRs unless manually approved by a maintainer. It's a security measure. You should have something like this in the PR: |
|
If there's no button to approve my new workflow, I may have a configuration issue blocking it. |
No, I do not see it. As mentioned in previous comment, you need to add It's OK, we can merge this PR for now, and see the workflow on main branch. |
|
I found the issue. I'll open a new PR to address it. |
- Add lint.yaml and lint_template.yaml to run golangci-lint as a dedicated job for both Linux and Windows, using shell: bash to ensure works correctly on Windows runners. - Remove golangci-lint steps from tests-template.yml and tests_windows.yml; lint is now handled exclusively by lint.yaml. - Fix Windows Go version setup by using go-version-file in tests_windows.yml instead of the two-step goversion approach. Ref: etcd-io#1181
- Add lint.yaml and lint_template.yaml to run golangci-lint as a dedicated job for both Linux and Windows, using shell: bash to ensure works correctly on Windows runners. - Remove golangci-lint steps from tests-template.yml and tests_windows.yml; lint is now handled exclusively by lint.yaml. - Fix Windows Go version setup by using go-version-file in tests_windows.yml instead of the two-step goversion approach. Ref: etcd-io#1181 Signed-off-by: Mark Tsai <111229657+shuan1026@users.noreply.github.com>
- Add lint.yaml and lint_template.yaml to run golangci-lint as a dedicated job for both Linux and Windows, using shell: bash to ensure works correctly on Windows runners. - Remove golangci-lint steps from tests-template.yml and tests_windows.yml; lint is now handled exclusively by lint.yaml. - Fix Windows Go version setup by using go-version-file in tests_windows.yml instead of the two-step goversion approach. Ref: etcd-io#1181 Signed-off-by: Mark Tsai <111229657+shuan1026@users.noreply.github.com>
- Add lint.yaml and lint_template.yaml to run golangci-lint as a dedicated job for both Linux and Windows, using shell: bash to ensure works correctly on Windows runners. - Remove golangci-lint steps from tests-template.yml and tests_windows.yml; lint is now handled exclusively by lint.yaml. - Fix Windows Go version setup by using go-version-file in tests_windows.yml instead of the two-step goversion approach. Ref: etcd-io#1181 Signed-off-by: Mark Tsai <111229657+shuan1026@users.noreply.github.com>
5 participants
Ref: #1178 (comment)