reverse_tunnels: Fix some flakes in the reverse connection cluster integration test#44065
Open
aakugan wants to merge 1 commit intoenvoyproxy:mainfrom
Open
reverse_tunnels: Fix some flakes in the reverse connection cluster integration test#44065aakugan wants to merge 1 commit intoenvoyproxy:mainfrom
aakugan wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
aakugan
requested review from
agrawroh,
botengyao and
yanavlasov
as code owners
basundhara-c
approved these changes
Mar 21, 2026
Contributor
Author
|
/retest |
Signed-off-by: aakugan <aakashganapathy2@gmail.com>
aakugan
force-pushed
the
flak-rc-integ-test
branch
from
4999e6a to
8e12a38
Compare
aakugan
changed the title
agrawroh
reviewed
Mar 22, 2026
Member
agrawroh
left a comment
agrawroh
left a comment
There was a problem hiding this comment.
cc @basundhara-c Could you please do the first pass?
Contributor
|
looks good to me @agrawroh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message
Fix some flakes in the reverse connection cluster integration test.
Additional Description
Wait for the listener to accept the connection before sending the requests to prevent a bunch of races that could come otherwise. We can take up finding and fixing the races later as it should not be easy to hit when run on different machines the accept window is usually very small only when done from a single machine does it become more likely.
Enable auto_close_connections by default othewise we risk letting both sockets be alive and reading from the same kernel socket which can cause other issues -> also add in ssl_quiet_close so the connection is not force closed by the ssl socket on the downstream side.
Testing
Unit and integ tests.