dotnetup: Unify version properties across projects#53473
Merged
nagilson merged 2 commits intodotnet:release/dnupfrom Mar 17, 2026
Merged
dotnetup: Unify version properties across projects#53473nagilson merged 2 commits intodotnet:release/dnupfrom
nagilson merged 2 commits intodotnet:release/dnupfrom
Conversation
Define DotnetupVersionPrefix and DotnetupPreReleaseVersionLabel in a shared src/Installer/Directory.Build.props so both projects inherit the same version. This prevents version drift between the CLI tool and the library. Fixes dotnet#52795 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Centralizes dotnetup and Microsoft.Dotnet.Installation versioning under src/Installer so both projects build/package with a single, shared version source of truth.
Changes:
- Added
src/Installer/Directory.Build.propsdefining sharedDotnetupVersionPrefixandDotnetupPreReleaseVersionLabel. - Updated
dotnetup.csprojandMicrosoft.Dotnet.Installation.csprojto use the shared properties instead of hardcoded version values.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Installer/Directory.Build.props | Introduces shared version properties for the Installer subtree (while importing the repo’s parent Directory.Build.props). |
| src/Installer/dotnetup/dotnetup.csproj | Switches VersionPrefix/PreReleaseVersionLabel to shared properties. |
| src/Installer/Microsoft.Dotnet.Installation/Microsoft.Dotnet.Installation.csproj | Switches VersionPrefix/PreReleaseVersionLabel to shared properties. |
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Centralizes version properties for dotnetup and Microsoft.Dotnet.Installation into a shared
Directory.Build.propsso both projects stay in sync.Changes
src/Installer/Directory.Build.propswith sharedDotnetupVersionPrefix(0.1.1) andDotnetupPreReleaseVersionLabel(preview) propertiesdotnetup.csprojandMicrosoft.Dotnet.Installation.csprojto reference shared properties instead of hardcoding version valuesConflicts
Warning
This branch conflicts with PR #53464 (walkthrough UX improvements) which also creates/modifies
src/Installer/Directory.Build.props.Note
This PR was created by Copilot CLI and has not yet been reviewed by a human.
Fixes #52795