Skip to content

dotnetup: Unify version properties across projects#53473

Merged
nagilson merged 2 commits intodotnet:release/dnupfrom
dsplaisted:dotnetup-unify-version
Mar 17, 2026
Merged

dotnetup: Unify version properties across projects#53473
nagilson merged 2 commits intodotnet:release/dnupfrom
dsplaisted:dotnetup-unify-version

Conversation

@dsplaisted
Copy link
Member

Summary

Centralizes version properties for dotnetup and Microsoft.Dotnet.Installation into a shared Directory.Build.props so both projects stay in sync.

Changes

  • Created src/Installer/Directory.Build.props with shared DotnetupVersionPrefix (0.1.1) and DotnetupPreReleaseVersionLabel (preview) properties
  • Updated dotnetup.csproj and Microsoft.Dotnet.Installation.csproj to reference shared properties instead of hardcoding version values

Conflicts

Warning

This branch conflicts with PR #53464 (walkthrough UX improvements) which also creates/modifies src/Installer/Directory.Build.props.

Note

This PR was created by Copilot CLI and has not yet been reviewed by a human.

Fixes #52795

Define DotnetupVersionPrefix and DotnetupPreReleaseVersionLabel in a
shared src/Installer/Directory.Build.props so both projects inherit
the same version. This prevents version drift between the CLI tool
and the library.

Fixes dotnet#52795

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dsplaisted dsplaisted added the dotnetup Work items around the proposed `dotnetup` bootstrapper/toolchain management tool and library label Mar 16, 2026
Copy link
Member

@nagilson nagilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea, thank you!

@nagilson nagilson marked this pull request as ready for review March 17, 2026 16:46
@nagilson nagilson requested a review from a team as a code owner March 17, 2026 16:46
Copilot AI review requested due to automatic review settings March 17, 2026 16:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Centralizes dotnetup and Microsoft.Dotnet.Installation versioning under src/Installer so both projects build/package with a single, shared version source of truth.

Changes:

  • Added src/Installer/Directory.Build.props defining shared DotnetupVersionPrefix and DotnetupPreReleaseVersionLabel.
  • Updated dotnetup.csproj and Microsoft.Dotnet.Installation.csproj to use the shared properties instead of hardcoded version values.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/Installer/Directory.Build.props Introduces shared version properties for the Installer subtree (while importing the repo’s parent Directory.Build.props).
src/Installer/dotnetup/dotnetup.csproj Switches VersionPrefix/PreReleaseVersionLabel to shared properties.
src/Installer/Microsoft.Dotnet.Installation/Microsoft.Dotnet.Installation.csproj Switches VersionPrefix/PreReleaseVersionLabel to shared properties.

You can also share your feedback on Copilot code review. Take the survey.

@nagilson nagilson merged commit 35ffdb5 into dotnet:release/dnup Mar 17, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dotnetup Work items around the proposed `dotnetup` bootstrapper/toolchain management tool and library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants