dotnetup: Accept 'aspnet' as alias for 'aspnetcore' runtime type#53472
Draft
dsplaisted wants to merge 1 commit intodotnet:release/dnupfrom
Draft
dotnetup: Accept 'aspnet' as alias for 'aspnetcore' runtime type#53472dsplaisted wants to merge 1 commit intodotnet:release/dnupfrom
dsplaisted wants to merge 1 commit intodotnet:release/dnupfrom
Conversation
Define DotnetupVersionPrefix and DotnetupPreReleaseVersionLabel in a shared src/Installer/Directory.Build.props so both projects inherit the same version. This prevents version drift between the CLI tool and the library. Fixes dotnet#52795 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dsplaisted
added
the
dotnetup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
aspnetas an accepted alias for theaspnetcoreruntime type, so users can type either:The alias is accepted in parsing but not shown in help/error messages to keep them clean.
Changes
aspnet→InstallComponent.ASPNETCoremapping inRuntimeInstallCommand.s_runtimeTypeMaps_canonicalRuntimeTypeNamesarray for display in error messages (avoids showing bothaspnetandaspnetcore)GetValidRuntimeTypes()to iterate canonical namesConflicts
Warning
This branch conflicts with PR #53464 (walkthrough UX improvements) due to overlapping changes in
RuntimeInstallCommand.cs.Note
This PR was created by Copilot CLI and has not yet been reviewed by a human.
Fixes #53283