Skip to content

Embed AnalyzerConfigFiles in binlog #82741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Embed AnalyzerConfigFiles in binlog #82741

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d091a98
Initial plan
Copilot Mar 13, 2026
fee8317
Add AnalyzerConfigFiles (EditorConfigFiles) to EmbedInBinlog item group
Copilot Mar 13, 2026
e5ede2f
Address review feedback: add WorkItem, use raw string literal, verify…
Copilot Mar 13, 2026
79c6a1f
Move EmbedInBinlog for EditorConfigFiles into _BeforeVBCSCoreCompile …
Copilot Mar 13, 2026
86792ea
Move EmbedInBinlog into CoreCompile; make test cross-platform with ra…
Copilot Mar 13, 2026
81abf6a
Improve formatting
jjonescz Mar 13, 2026
be0090f
Remove redundant item
jjonescz Mar 13, 2026
3024572
Fixup tests
jjonescz Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Compilers/Core/MSBuildTask/Microsoft.Managed.Core.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,8 @@

<GlobalAnalyzerConfigFiles Include="@(_AllDirectoriesAbove->'%(FullPath)'->Distinct()->Combine('.globalconfig'))" Condition="'$(DiscoverGlobalAnalyzerConfigFiles)' != 'false'" />
<EditorConfigFiles Include="@(GlobalAnalyzerConfigFiles->Exists())" Condition="'$(DiscoverGlobalAnalyzerConfigFiles)' != 'false'" />

<EmbedInBinlog Include="@(EditorConfigFiles)" />
</ItemGroup>

<!--
Expand Down Expand Up @@ -192,6 +194,7 @@
<!-- Record that we'll write a file, and add it to the analyzerconfig inputs -->
<FileWrites Include="$(GeneratedMSBuildEditorConfigFile)" />
<EditorConfigFiles Include="$(GeneratedMSBuildEditorConfigFile)" />
<EmbedInBinlog Include="$(GeneratedMSBuildEditorConfigFile)" />
</ItemGroup>

<!-- Transform the collected properties and items into an editor config file -->
Expand Down
24 changes: 24 additions & 0 deletions src/Compilers/Core/MSBuildTaskTests/TargetTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,6 +540,30 @@ public void GenerateEditorConfigIsPassedToTheCompiler()
Assert.Single(items);
}

[Fact]
public void GenerateEditorConfigIsEmbeddedInBinlog()
{
XmlReader xmlReader = XmlReader.Create(new StringReader($@"
<Project>
<Import Project=""Microsoft.Managed.Core.targets"" />

<ItemGroup>
<CompilerVisibleProperty Include=""prop"" />
</ItemGroup>
</Project>
"));

var instance = CreateProjectInstance(xmlReader);

bool runSuccess = instance.Build(target: "GenerateMSBuildEditorConfigFile", GetTestLoggers());
Assert.True(runSuccess);

var editorConfigItems = instance.GetItems("EditorConfigFiles");
var embedInBinlogItems = instance.GetItems("EmbedInBinlog");
Assert.Single(editorConfigItems);
Assert.Contains(embedInBinlogItems, item => item.EvaluatedInclude == editorConfigItems.Single().EvaluatedInclude);
}

[Fact]
public void AdditionalFilesAreAddedToNoneWhenCopied()
{
Expand Down
Loading