Open
Conversation
Co-authored-by: jjonescz <3669664+jjonescz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add embedding of analyzer config files in binlog
Embed AnalyzerConfigFiles in binlog
Mar 13, 2026
jjonescz
reviewed
Mar 13, 2026
… file contents Co-authored-by: jjonescz <3669664+jjonescz@users.noreply.github.com>
jjonescz
approved these changes
Mar 13, 2026
JoeRobich
approved these changes
Mar 13, 2026
Youssef1313
reviewed
Mar 13, 2026
…target and add test Co-authored-by: jjonescz <3669664+jjonescz@users.noreply.github.com>
Youssef1313
reviewed
Mar 13, 2026
jjonescz
reviewed
Mar 13, 2026
…w string literals Co-authored-by: jjonescz <3669664+jjonescz@users.noreply.github.com>
jjonescz
reviewed
Mar 13, 2026
Co-authored-by: Jan Jones <jan.jones.cz@gmail.com>
JoeRobich
approved these changes
Mar 13, 2026
Youssef1313
reviewed
Mar 13, 2026
Youssef1313
approved these changes
Mar 14, 2026
Member
|
@jaredpar FYI |
jasonmalinowski
approved these changes
Mar 17, 2026
jaredpar
approved these changes
Mar 17, 2026
Member
|
@dotnet/roslyn-compiler for the second compiler review, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
AnalyzerConfigFiles(EditorConfigFiles) to theEmbedInBinlogitem group so their exact content is captured in binary logs.Changes Made
<EmbedInBinlog Include="@(EditorConfigFiles)" />at the top of theCoreCompiletarget body in bothMicrosoft.CSharp.Core.targetsandMicrosoft.VisualBasic.Core.targets. Placing it insideCoreCompile(rather than a static evaluation-timeItemGroup) ensures thatEditorConfigFilesadded by analyzer packages (e.g., NetAnalyzers, CodeStyle) in their ownBeforeTargets="CoreCompile"targets are captured.CoreCompileinDotNetSdkTestBase.csto include the sameEmbedInBinlogItemGroup so SDK tests continue to work.GenerateEditorConfigIsEmbeddedInBinlogtest inTargetTests.csverifying the MSBuild-generated editor config is embedded and its contents are correct.TestEditorConfigFilesAddedByAnalyzerPackagesAreEmbeddedInBinlogtest inDotNetSdkTests.cssimulating an analyzer package adding anEditorConfigFileviaBeforeTargets="CoreCompile"and verifying it appears in@(EmbedInBinlog). The test disables automatic discovery for deterministic, cross-platform results.Original prompt
📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.
Microsoft Reviewers: Open in CodeFlow