Skip to content

Update Microsoft.CodeAnalysis.Analyzers to a release version #82719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JoeRobich wants to merge 6 commits into
base: release/dev18.3
Choose a base branch
from
Open

Update Microsoft.CodeAnalysis.Analyzers to a release version #82719

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
61c275b
Update Microsoft.CodeAnalysis.Analyzers to a release version
JoeRobich Mar 12, 2026
5ea597f
Don't change version in SourceBuild
JoeRobich Mar 12, 2026
99f0bb8
Add comment
JoeRobich Mar 12, 2026
b7fa11a
Move the M.CA.Analyzers version override to Packages.props
JoeRobich Mar 12, 2026
9628fe3
Fix
JoeRobich Mar 12, 2026
294e59b
Fix up sarif files
JoeRobich Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/Version.Details.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ This file should be imported by eng/Versions.props
<SystemCommandLineVersion>$(SystemCommandLinePackageVersion)</SystemCommandLineVersion>
<!-- dotnet-roslyn dependencies -->
<MicrosoftCodeAnalysisVersion>$(MicrosoftCodeAnalysisPackageVersion)</MicrosoftCodeAnalysisVersion>
<MicrosoftCodeAnalysisAnalyzersVersion>$(MicrosoftCodeAnalysisAnalyzersPackageVersion)</MicrosoftCodeAnalysisAnalyzersVersion>
Copy link
Member

@jjonescz jjonescz Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not change the value of MicrosoftCodeAnalysisAnalyzersPackageVersion instead? (and perhaps also the corresponding values in version.details.xml)

Copy link
Member Author

@JoeRobich JoeRobich Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to change the SourceBuild information. Maybe conditionally setting the version will be more clean.

Copy link
Member

@jjonescz jjonescz Mar 12, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But manual changes in this file will be overridden on next bot update. I guess it's fine since we just want to have a build to publish and then we don't care...

Copy link
Member

@jjonescz jjonescz Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Otherwise if you want I guess it would be better to just move this <MicrosoftCodeAnalysisAnalyzersVersion Condition="Condition="'$(DotNetBuildSourceOnly)' != 'true'">5.3.0</MicrosoftCodeAnalysisAnalyzersVersion> line to some other file that is not bot-managed.)

Copy link
Member Author

@JoeRobich JoeRobich Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. To Packages.props it goes!

Copy link
Member

@akoeplinger akoeplinger Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoeRobich @jjonescz source build will override the version so you can just update the Version.Details.xml/.props

Copy link
Member

@jjonescz jjonescz Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But then maestro could overwrite that file, no?

Copy link
Member

@akoeplinger akoeplinger Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That depends on the subscription, but it looks like we have a cycle here if Microsoft.CodeAnalysis.Analyzers is a dependency of Microsoft.CodeAnalysis but is built in the sdk repo after roslyn.

/cc @dotnet/source-build

Copy link
Member Author

@JoeRobich JoeRobich Mar 13, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this servicing branch I would like to leave it as is. I think our goal for main should be to move it to project references during the build with the appropriate package dependency when packed.

Copy link
Member Author

@JoeRobich JoeRobich Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am taking advice on that last part.

<MicrosoftCodeAnalysisAnalyzersVersion>5.3.0</MicrosoftCodeAnalysisAnalyzersVersion>
<MicrosoftCodeAnalysisAnalyzerUtilitiesVersion>$(MicrosoftCodeAnalysisAnalyzerUtilitiesPackageVersion)</MicrosoftCodeAnalysisAnalyzerUtilitiesVersion>
<MicrosoftNetCompilersToolsetVersion>$(MicrosoftNetCompilersToolsetPackageVersion)</MicrosoftNetCompilersToolsetVersion>
<RoslynDiagnosticsAnalyzersVersion>$(RoslynDiagnosticsAnalyzersPackageVersion)</RoslynDiagnosticsAnalyzersVersion>
Expand Down
2 changes: 1 addition & 1 deletion eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<PropertyGroup>
<MajorVersion>5</MajorVersion>
<MinorVersion>3</MinorVersion>
<PatchVersion>0</PatchVersion>
<PatchVersion>1</PatchVersion>
<PreReleaseVersionLabel>2</PreReleaseVersionLabel>
<PreReleaseVersionLabel Condition="'$(DotNetSignType)' == 'test'">$(PreReleaseVersionLabel)-test</PreReleaseVersionLabel>
<VersionPrefix>$(MajorVersion).$(MinorVersion).$(PatchVersion)</VersionPrefix>
Expand Down
Loading