Skip to content

Update Microsoft.CodeAnalysis.Analyzers to a release version #82719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JoeRobich wants to merge 6 commits into
base: release/dev18.3
Choose a base branch
from
+23 −22
Open

Update Microsoft.CodeAnalysis.Analyzers to a release version #82719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
61c275b
Update Microsoft.CodeAnalysis.Analyzers to a release version
JoeRobich Mar 12, 2026
5ea597f
Don't change version in SourceBuild
JoeRobich Mar 12, 2026
99f0bb8
Add comment
JoeRobich Mar 12, 2026
b7fa11a
Move the M.CA.Analyzers version override to Packages.props
JoeRobich Mar 12, 2026
9628fe3
Fix
JoeRobich Mar 12, 2026
294e59b
Fix up sarif files
JoeRobich Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions eng/Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,10 +159,11 @@

<!--
Since the Microsoft.CodeAnalysis.Analyzers package is a public dependency of our NuGet
packages we will keep it untied to the RoslynDiagnosticsAnalyzersPackageVersion we use for
other analyzers to ensure it stays on a release version.
packages, when not in SourceBuild we will keep it untied to the MicrosoftCodeAnalysisAnalyzersVersion
we use for other analyzers to ensure it stays on a release version.
-->
<PackageVersion Include="Microsoft.CodeAnalysis.Analyzers" Version="$(MicrosoftCodeAnalysisAnalyzersVersion)" />
<PackageVersion Condition="'$(DotNetBuildSourceOnly)' != 'true'" Include="Microsoft.CodeAnalysis.Analyzers" Version="5.3.0" />
Copy link
Member

@jasonmalinowski jasonmalinowski Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this is targeting dev18.3 as a branch -- do we need to do something similar for other branches, or was something better done in later branches and this is a unique problem for this branch?

Copy link
Member Author

@JoeRobich JoeRobich Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ideally we wouldn't be behind. We would use project references for our build, but I need to talk to someone more knowledgeable here since Microsoft.CodeAnalysis.Analyzer.Package is a project that packages other analyzer projects.

Could see making the same change in main so if we aren't able to work out the details we don't regress.

<PackageVersion Condition="'$(DotNetBuildSourceOnly)' == 'true'" Include="Microsoft.CodeAnalysis.Analyzers" Version="$(MicrosoftCodeAnalysisAnalyzersVersion)" />
<PackageVersion Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="$(MicrosoftCodeAnalysisNetAnalyzersVersion)" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp.CodeStyle" Version="$(CodeStyleAnalyzerVersion)" />
<PackageVersion Include="Microsoft.CodeAnalysis.VisualBasic.CodeStyle" Version="$(CodeStyleAnalyzerVersion)" />
Expand Down
2 changes: 1 addition & 1 deletion eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<PropertyGroup>
<MajorVersion>5</MajorVersion>
<MinorVersion>3</MinorVersion>
<PatchVersion>0</PatchVersion>
<PatchVersion>1</PatchVersion>
<PreReleaseVersionLabel>2</PreReleaseVersionLabel>
<PreReleaseVersionLabel Condition="'$(DotNetSignType)' == 'test'">$(PreReleaseVersionLabel)-test</PreReleaseVersionLabel>
<VersionPrefix>$(MajorVersion).$(MinorVersion).$(PatchVersion)</VersionPrefix>
Expand Down
6 changes: 3 additions & 3 deletions src/RoslynAnalyzers/Microsoft.CodeAnalysis.Analyzers/Microsoft.CodeAnalysis.Analyzers.sarif
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
{
"tool": {
"name": "Microsoft.CodeAnalysis.Analyzers",
"version": "5.3.0",
"version": "5.3.1",
"language": "en-US"
},
"rules": {
Expand Down Expand Up @@ -724,7 +724,7 @@
{
"tool": {
"name": "Microsoft.CodeAnalysis.CSharp.Analyzers",
"version": "5.3.0",
"version": "5.3.1",
"language": "en-US"
},
"rules": {
Expand Down Expand Up @@ -957,7 +957,7 @@
{
"tool": {
"name": "Microsoft.CodeAnalysis.VisualBasic.Analyzers",
"version": "5.3.0",
"version": "5.3.1",
"language": "en-US"
},
"rules": {
Expand Down
6 changes: 3 additions & 3 deletions ...Microsoft.CodeAnalysis.BannedApiAnalyzers/Microsoft.CodeAnalysis.BannedApiAnalyzers.sarif
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
{
"tool": {
"name": "Microsoft.CodeAnalysis.BannedApiAnalyzers",
"version": "5.3.0",
"version": "5.3.1",
"language": "en-US"
},
"rules": {
Expand All @@ -14,7 +14,7 @@
{
"tool": {
"name": "Microsoft.CodeAnalysis.CSharp.BannedApiAnalyzers",
"version": "5.3.0",
"version": "5.3.1",
"language": "en-US"
},
"rules": {
Expand Down Expand Up @@ -77,7 +77,7 @@
{
"tool": {
"name": "Microsoft.CodeAnalysis.VisualBasic.BannedApiAnalyzers",
"version": "5.3.0",
"version": "5.3.1",
"language": "en-US"
},
"rules": {
Expand Down
6 changes: 3 additions & 3 deletions .../PerformanceSensitiveAnalyzers/Microsoft.CodeAnalysis.PerformanceSensitiveAnalyzers.sarif
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
{
"tool": {
"name": "Microsoft.CodeAnalysis.CSharp.PerformanceSensitiveAnalyzers",
"version": "5.3.0",
"version": "5.3.1",
"language": "en-US"
},
"rules": {
Expand Down Expand Up @@ -184,7 +184,7 @@
{
"tool": {
"name": "Microsoft.CodeAnalysis.CSharp.PerformanceSensitiveAnalyzers.CodeFixes",
"version": "5.3.0",
"version": "5.3.1",
"language": "en-US"
},
"rules": {
Expand All @@ -193,7 +193,7 @@
{
"tool": {
"name": "Microsoft.CodeAnalysis.PerformanceSensitiveAnalyzers",
"version": "5.3.0",
"version": "5.3.1",
"language": "en-US"
},
"rules": {
Expand Down
4 changes: 2 additions & 2 deletions src/RoslynAnalyzers/PublicApiAnalyzers/Microsoft.CodeAnalysis.PublicApiAnalyzers.sarif
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
{
"tool": {
"name": "Microsoft.CodeAnalysis.PublicApiAnalyzers",
"version": "5.3.0",
"version": "5.3.1",
"language": "en-US"
},
"rules": {
Expand Down Expand Up @@ -460,7 +460,7 @@
{
"tool": {
"name": "Microsoft.CodeAnalysis.PublicApiAnalyzers.CodeFixes",
"version": "5.3.0",
"version": "5.3.1",
"language": "en-US"
},
"rules": {
Expand Down
6 changes: 3 additions & 3 deletions src/RoslynAnalyzers/Roslyn.Diagnostics.Analyzers/Roslyn.Diagnostics.Analyzers.sarif
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
{
"tool": {
"name": "Roslyn.Diagnostics.Analyzers",
"version": "5.3.0",
"version": "5.3.1",
"language": "en-US"
},
"rules": {
Expand Down Expand Up @@ -157,7 +157,7 @@
{
"tool": {
"name": "Roslyn.Diagnostics.CSharp.Analyzers",
"version": "5.3.0",
"version": "5.3.1",
"language": "en-US"
},
"rules": {
Expand Down Expand Up @@ -300,7 +300,7 @@
{
"tool": {
"name": "Roslyn.Diagnostics.VisualBasic.Analyzers",
"version": "5.3.0",
"version": "5.3.1",
"language": "en-US"
},
"rules": {
Expand Down
8 changes: 4 additions & 4 deletions src/RoslynAnalyzers/Text.Analyzers/Text.Analyzers.sarif
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
{
"tool": {
"name": "Humanizer",
"version": "5.3.0",
"version": "5.3.1",
"language": "en-US"
},
"rules": {
Expand All @@ -14,7 +14,7 @@
{
"tool": {
"name": "Text.Analyzers",
"version": "5.3.0",
"version": "5.3.1",
"language": "en-US"
},
"rules": {
Expand Down Expand Up @@ -86,7 +86,7 @@
{
"tool": {
"name": "Text.CSharp.Analyzers",
"version": "5.3.0",
"version": "5.3.1",
"language": "en-US"
},
"rules": {
Expand All @@ -95,7 +95,7 @@
{
"tool": {
"name": "Text.VisualBasic.Analyzers",
"version": "5.3.0",
"version": "5.3.1",
"language": "en-US"
},
"rules": {
Expand Down